[ros-bugs] [Bug 1600] calculator garbage values

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=1600





------- Comment #2 from jimtabor at adsl-64-217-116-74.dsl.hstntx.swbell.net  2006-07-16 11:37 CET -------
I track this down to SetMenuItemInfoA/W, from winecalc.c:

void calc_setmenuitem_radio(HMENU hMenu, UINT id)
{
    MENUITEMINFO menuItem;

    menuItem.fMask         = MIIM_FTYPE;
    menuItem.fType         = MFT_STRING | MFT_RADIOCHECK;
    //   menuItem.fState        = MFS_ENABLED;
    //   menuItem.wID           = id;
    //   menuItem.hSubMenu      = NULL;
    //   menuItem.hbmpChecked   = NULL;
    //   menuItem.hbmpUnchecked = NULL;
    //   menuItem.dwItemData    = 0;
    //   menuItem.dwTypeData    = "Hex\tF5";
    //   menuItem.cch           = sizeof("Hex\tF5");
    menuItem.cbSize        = sizeof(MENUITEMINFO);

    SetMenuItemInfo(hMenu, id, FALSE, &menuItem);
}

I see in user32 menu.c and win32k menu.c how this can become a problem. With
MFT_STRING set it will assume dwTypeData has a real address. I'm in the
processes of fixing this ATM. I tested Ros calc.exe on 2K/XP/Wine and it works
fine.
James


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
You are the assignee for the bug, or are watching the assignee.