[ros-bugs] [Bug 1790] setup fails to format if drive is not partitioned

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=1790





------- Comment #5 from mail at colinfinck.de  2007-03-21 18:38 CET -------
I've looked into the bug and at least I found out, where the bug occurs.

On the first boot on a fresh hard disk, the disk device state is still
DO_DEVICE_INITIALIZING before the formatting.
You can check this if you enable debugging in "ntoskrnl\io\iomgr\file.c". Then
"file.c" reports that the disk driver sucks ;-)
If you add the following code after line 144:

  if(DeviceObject->Flags & DO_DEVICE_INITIALIZING)
    DPRINT("IopCheckDeviceAndDriver: Device is still initializing\n");

this debug message also gets printed. This should make it obvious that the
device is still in the initialization state.
This debug message won't be printed on the second boot, when the partition
format works.

If I now change the code, so that it also jumps to the "else" branch even if
the device state is still DO_DEVICE_INITIALIZING, formatting partitions also
works on first boot on an unpartitioned disk.
But this is a very ugly hack ;-)

Therefore I conclude that someone forgot to unset DO_DEVICE_INITIALIZING in the
disk driver or another component.
As I am not a kernel and driver expert, maybe some other developers could take
a look at this problem.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
You are the assignee for the bug, or are watching the assignee.