[ros-bugs] [Bug 2706] Fixed rbuild CdFile , InstallFile and Bottstrap 'base' attribute inconsistency

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=2706


piulachs <marc.piulachs at codexchange.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1966 is|0                           |1
           obsolete|                            |
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #3 from piulachs <marc.piulachs at codexchange.net>  2007-10-01 16:37:32 CET ---
Created an attachment (id=1972)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1972)
patch

additional fix for rosapp's green driver I missed in my previous patch

BTW , why is this driver added to the CD ? What is It used for?


--- Comment #4 from piulachs <marc.piulachs at codexchange.net>  2007-10-01 16:39:32 CET ---
missing rosapps green driver


--- Comment #5 from piulachs <marc.piulachs at codexchange.net>  2007-10-02 01:49:36 CET ---
Created an attachment (id=1976)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1976)
the patch

A couple of additional fixes to rbuild files I also forgot to add to the
original patch:

- removed the $(CDOUTPUT) var from installbase and replaced by a fixed value.
(like the rest of modules)

The reason is that even it works it places an inecessary mingw backend specific
resolved FULL path to 'installbase' inset of a RELATIVE neutral one which is
more adecuate and correct.


--- Comment #6 from hpoussin <hpoussin at reactos.org>  2007-10-02 11:44:00 CET ---
> - removed the $(CDOUTPUT) var from installbase and replaced by a fixed value. 
(like the rest of modules)

I don't agree with this change. You have to take care of ROS_CDOUTPUT 
environment variable.
>From Makefile:
#    ROS_CDOUTPUT
#        This variable controls the name of the ReactOS directory on cdrom.
#        The variable defaults to reactos.
#        Warning: setting this value may lead to a not bootable/installable 
cdrom.

The not bootable/installable cdrom is a bootsect  issue, which has to be taken 
care separately.
One day, we might even put multiple architectures binaries on one CD 
(directories I386, PPC...).


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.