[ros-bugs] [Bug 2711] Notepad: fixes for non-unicode and more

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=2711


amine48rz <amine48rz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ros-bugs at reactos.org        |hpoussin at reactos.org
             Status|NEW                         |ASSIGNED




--- Comment #2 from hpoussin <hpoussin at reactos.org>  2007-10-08 09:06:47 CET ---
- QueryString/SaveString should save the same data to registry, notepad beeing 
compiled with or without unicode support
- The UNICODE/_UNICODE defines in .rbuild should be removed and replaced by a 
'unicode="yes"' attribute in the module element
- You don't do any error checking in ConvertToASCII/ConvertToUNICODE (return 
codes from WideCharToMultiByte/MultiByteToWideChar/HeapAlloc)
- In DoSaveFile, why not use GetWindowTextW, instead of ugly casts?
- In DoOpenFile, why not use SetWindowTextW, instead of ugly casts?


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.