[ros-bugs] [Bug 2711] Notepad: fixes for non-unicode and more

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=2711


Carlo Bramix <carlo.bramix at libero.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1979 is|0                           |1
           obsolete|                            |

hpoussin <hpoussin at reactos.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Carlo Bramix <carlo.bramix at libero.it>  2007-10-08 16:03:09 CET ---
1) probably I didn't understand the problem.
It seems to me that QueryString/SaveString handle that correctly.
REG_SZ accepts chars in ascii version and wchars in unicode.

2) I was inspired by the .rbuild file of calc application, but if there is a
better place, I totally agree.

3) You are right, it's better to check the results of these functions too.

4) and 5) GetWindowTextW/SetWindowTextW is unsupported in Windows 95/98/Me.
A pure ascii application cannot use them unless if compiled with unicode
compatibility layer.


--- Comment #4 from Carlo Bramix <carlo.bramix at libero.it>  2007-10-08 18:06:56 CET ---
1) probably I didn't understand the problem.
It seems to me that QueryString/SaveString handle that correctly.
REG_SZ accepts chars in ascii version and wchars in unicode.

2) I was inspired by the .rbuild file of calc application, but if there is a
better place, I totally agree.

3) You are right, it's better to check the results of these functions too.

4) and 5) GetWindowTextW/SetWindowTextW is unsupported in Windows 95/98/Me.
A pure ascii application cannot use them unless if compiled with unicode
compatibility layer. Sad but true.


--- Comment #5 from Carlo Bramix <carlo.bramix at libero.it>  2007-10-08 19:54:01 CET ---
Created an attachment (id=1999)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=1999)
Fixed Patch

this patch fixes the unicode declaration and it adds additional checks to
ConvertToASCII() and ConvertToUNICODE() functions.


--- Comment #6 from hpoussin <hpoussin at reactos.org>  2007-10-09 10:54:20 CET ---
Fixed in r29466.
http://www.reactos.org/archives/public/ros-diffs/2007-October/019160.html


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.