[ros-bugs] [Bug 3216] New: rbuild: nested "if" bug

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3216

           Summary: rbuild: nested "if" bug
           Product: ReactOS
           Version: unspecified
          Platform: QEmu
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Patches
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: marc.piulachs at codexchange.net
         QAContact: ros-bugs at reactos.org


Created an attachment (id=2471)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2471)
patch

Attached is a small Hal modules reorganization patch. I was trying to avoid
using alias by using conditional logic.

In hal\halx86\directory.rbuild we have :

        <if property="SARCH" value="">
                <module name="halup" type="kernelmodedll" entrypoint="0" >
                   (...)
                </module>

                <module name="halmp" type="kernelmodedll" entrypoint="0"
installname="halmp.dll">
                   (...)                
                </module>
        </if>

        <if property="SARCH" value="xbox">
                <module name="halup" type="kernelmodedll" entrypoint="0"
allowwarnings="true" installname="hal.dll">
                   (...)
                </module>
        </if>

SARCH is defined as <property name="SARCH" value="" /> on config.template so
modules halup and halmp should be included in the makefile.

rbuild is just omitting both modules even the condition is meet. While
debugging I have seen than rbuild is properly parsing the rbuild file but "if"
child nodes are not executed.

when "ifs" are removed the modules are created with any problem so rbuild is
reading this file.

I have also tried changing "if" with "ifnot" , the effect is the same , if the
SARCH value was not "" the nodes should be executed but they are not. So it's
clearly a bug

Attached the patch to reproduce this problem


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.