[ros-bugs] [Bug 2964] heap unimplemented

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=2964





--- Comment #5 from pjasnos <pawel.jasnos at gmail.com>  2008-05-11 22:58:12 CET ---
Hello Oriol, 

I have been looking at the diff you submitted and the original files, and this
is what I think they actually do - could you please confirm that?

Ok, here is the list:

+ Minor patch to HEAP_GetPtr to include magic value in debug output
+ Fixing the parameters checking in HEAP_InitSubHeap (it is currently not usede 
  -  put between #if 0/#endif)
+correcting HEAP_FindFreeBlock which was logging error message as warning
(while still returning NULL to caller) by changing severity of logged message
+Implementing RtlEnumProcessHeaps (previously stubbed out).
+Fixing sanity checks in and implementation of RtlGetProcessHeaps (previously
the 
  function was not checking for the counter value, and also was not assigning 
  anything to the returned value; now this seems to be corrected.
+Fixing RtlValidateProcessHeaps implementation (the function was stubbed out 
 because (most probably, I wasn't able to find a bug mentioning this) it was 
 previously using a global lock for all heaps (which probably could cause some 
 problems in the kernel), now it only locks heaps belonging to the given
process  
  - and this is the correct behaviour.

I thought that as this bug is listed as a blocker for the 0.3.5 release (and
really, we've got a patch - what we don't have, is the creator name and
description of fixes), I will try to do it given the age of this bug.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.