[ros-bugs] [Bug 3267] New: Miscellaneous console bugfixes

ReactOS.Bugzilla at www.reactos.org ReactOS.Bugzilla at www.reactos.org
Thu May 22 15:44:59 CEST 2008


http://www.reactos.org/bugzilla/show_bug.cgi?id=3267

           Summary: Miscellaneous console bugfixes
           Product: ReactOS
           Version: TRUNK
          Platform: QEmu
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Win32
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: mrnobo1024 at yahoo.com
         QAContact: ros-bugs at reactos.org


The attached patch fixes various console bugs, mostly exposed by the winetest.
It includes the following changes:

FreeConsole: Set ProcessParameters->ConsoleHandle to NULL.
WriteConsole: Going to a new line only clears it if at the bottom of the screen
buffer.
WriteConsole: Tab writes attributes as well as characters
ScrollConsoleScreenBuffer:
  Source rect being outside the screen buffer is not an error; it just doesn't
do anything.
  Destination is allowed to be outside the screen buffer. The source still gets
filled.
  Source may be outside the clip area. It is still copied, it is just not
filled.
  Rewrote the copying/filling code. Previously, there were problems when src
and dest overlapped - parts of the source could be overwritten before they were
moved, and it would not do the fill properly if the nonoverlapping part of the
source was not a rectangle.
SetConsoleActiveScreenBuffer: Don't leave Request->Status uninitialized.
Various output functions: Use output codepage instead of input codepage.
RemoveConsoleCtrlHandler: Return ERROR_INVALID_PARAMETER if handler not found.
GetConsoleInputExeName: Return ERROR_BUFFER_OVERFLOW if buffer too small.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the Ros-bugs mailing list