[ros-bugs] [Bug 4575] the window property HWND_TOPMOST can't be removed

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4575


ThePhysicist <timo.kreuzer at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timo.kreuzer at web.de




--- Comment #1 from ThePhysicist <timo.kreuzer at web.de>  2009-06-02 03:12:04 CET ---
What we do here is check if someone tries to remove WS_EX_TOPMOST from a window
that already has it and that has siblings that have it and then don't allow it.

Toplevel windows shouldn't have a parent and therefore no siblings. So the
check could be correct under "normal" conditions. I didn't test it though.
somebody should test this.

Our implementation uses ParentWindowHandle = pti->Desktop->DesktopWindow; as
default so we always have a parent and siblings.
[Also the same member of the WND structure is responsible for siblings and the
toplevel chain (see spwndNext in WND structure:
http://www.reactos.org/wiki/index.php/Techwiki/win32k/WND), so even if there
was no parent, the sibling member would be != NULL.]
I think the check could be fixed by adding && !(Window->Parent ==
Wnd->pdesktop->DesktopWindow) to check if we have a toplevel window.

Anyway, I don't know if this check really has any merit or is just some crap
that someone screwed up. If anyone fixes it, please add a comment.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.