[ros-bugs] [Bug 4934] rapps can't install any app (hangs)

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4934


LoveN <love.nystrom at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #4374 is|0                           |1
           obsolete|                            |




--- Comment #12 from LoveN <love.nystrom at gmail.com>  2009-11-05 21:10:44 CET ---
Created an attachment (id=4375)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=4375)
Correct patch for ThreadFunc infinite wait

In base\applications\rapps\loaddlg.c, Line 278:
After completing the download and launching the installer, 
ThreadProc does WaitForSingleObject( pi.hProcess, INFINITE ); 
If the installer runs into trouble and hangs, 
Rapps will appear hung because it's still waiting. 

I attach a new (tested) patch with a possible fix. 
The patch monitors the time ThreadFunc waits for the installer to finish. 
If the installer runs to completion, ThreadProc ends without further action.
Else, every 5 minutes a dialog pops up to ask if the user wants to keep
waiting.
If the response is IDNO the waiting ends, 
and the installer is killed with TerminateProcess.

Please delete patch 4374.

Best Regards // Love


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.