[ros-bugs] [Bug 4861] New: Remove bounds check from IsBadStringPtrA in kernel32/mem/isbad.c

ReactOS.Bugzilla at reactos.org ReactOS.Bugzilla at reactos.org
Sat Sep 26 18:10:01 CEST 2009


http://www.reactos.org/bugzilla/show_bug.cgi?id=4861

           Summary: Remove bounds check from IsBadStringPtrA in
                    kernel32/mem/isbad.c
           Product: ReactOS
           Version: TRUNK
          Platform: QEmu
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Win32
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: alwyn.tan at gmail.com
         QAContact: ros-bugs at reactos.org


Wine's implementation of IsBadBoundedStringPtr calls IsBadStringPtrA with
parameters (lpszStr, -1), see:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mapi32/util.c?annotate=32845#l487

However, our implementation of IsBadStringPtrA does a bounds check in line 221,
which would result in a non-zero return value when the second parameter is -1,
see:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/mem/isbad.c?annotate=37776#l221

Removing the bounds check should allow us to pass the following test in
mapi32:util:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/mapi32/util.c?revision=39773&view=markup#l_170


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Ros-bugs mailing list