[ros-bugs] [Bug 5611] PATCH: sc: Prevent crash command-line Service Control due to missing arguments

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=5611


Ged <gedmurphy at reactos.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gedmurphy at reactos.org




--- Comment #3 from Ged <gedmurphy at reactos.org>  2010-09-16 09:03:24 CET ---
Patch looks good, however the use of ServiceArgs in ParseCreateArguments is
weird.

Why are you dereferencing the pointer using the the zero array index, then
incrementing the pointer at the bottom of the loop?

Not that it's wrong, it's just a weird way of doing it. It would be better to
either dereference it using a pointer operator or use the array indices via the
ArgCount.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.