[ros-bugs] [Bug 6147] New: Service Control Manager does not set Tags correctly -> Vboxguest.sys shows up several times on boot screen

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=6147

           Summary: Service Control Manager does not set Tags correctly ->
                    Vboxguest.sys shows up several times on boot screen
           Product: ReactOS
           Version: TRUNK
          Platform: x86 Hardware
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Other
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: thfabba at gmx.de
         QAContact: ros-bugs at reactos.org


Created an attachment (id=6210)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=6210)
Screenshot of Vboxguest.sys being loaded multiple times

After installing VirtualBox (4.x) guest additions, the behavior shown in the
attached screenshot might occur: vboxguest.sys gets loaded (or only appears
not, not sure) multiple times. This number seemed to increase over time in my
tests.

I believe the problem is related to the Tag registry value that is assigned to
services.
This item determines (according to
HKLM\System\CurrentControlSet\Control\GroupOrderList) the order in which
services are loaded.
ReactOS gives each service the value 0 as a Tag (ScmAssignNewTag in
base\system\services.rpcserver.c), which results in the load order being
something like 2 1 0 0 0 0 0. This causes vboxguest.sys (or possibly another
service with Tag 0) to be loaded multiple times, and possibly prevents other
services from being started (not sure. If so, people should have stumbled upon
this ^^).
Assigning a random value in ScmAssignNewTag seemes to work around the issue.
The group order lists do not seem to contain any zeros anymore.

Additionally, the loader might also not be behaving correctly. Windows seems to
have multiple identical items in some group order lists as well, but I am not
sure what this means - the second occurrence could be ignored, or it could load
a second service with the same tag, so as to specify "any order". FreeLdr
doesn't do either of these as far as I can see. *g*


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.