[ros-bugs] [Bug 6148] New: Floppy drive uses CDROM ico in My Computer

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=6148

           Summary: Floppy drive uses CDROM ico in My Computer
           Product: ReactOS
           Version: TRUNK
          Platform: x86 Hardware
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Shell
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: mansonigor at gmail.com
         QAContact: ros-bugs at reactos.org


r51436. Floppy drive uses CDROM ico in My Computer.
Accordingly to this code from shell32/folders.c lines 252-262:
if (_ILGetDrive(pSimplePidl, sTemp, MAX_PATH))
        {
            switch(GetDriveTypeA(sTemp))
            {
                case DRIVE_REMOVABLE:   icon_idx = IDI_SHELL_FLOPPY;       
break;
                case DRIVE_CDROM:       icon_idx = IDI_SHELL_CDROM;        
break;
                case DRIVE_REMOTE:      icon_idx = IDI_SHELL_NETDRIVE;     
break;
                case DRIVE_RAMDISK:     icon_idx = IDI_SHELL_RAMDISK;      
break;
                case DRIVE_NO_ROOT_DIR: icon_idx = IDI_SHELL_CDROM;        
break;
            }
        }

it's because floppy drive is inaccessible. I didn't test what happen if
diskette is inserted but seems it must be replaced with floppy icon.
But it's ugly when instead of floppy ico we see cdrom ico. I think shell32 must
show floppy ico for floppy drive even when floppy is inaccessible(diskette is
not inserted)


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.