[ros-bugs] [Bug 6159] PATCH: Fix for the loading of the "KnownDlls" in SMSS

ReactOS.Bugzilla at reactos.org ReactOS.Bugzilla at reactos.org
Wed Apr 27 21:46:52 UTC 2011


http://www.reactos.org/bugzilla/show_bug.cgi?id=6159





--- Comment #10 from ekohl <eric.kohl at t-online.de>  2011-04-27 21:46:52 CET ---
vicmarcal:
These lines do nothing but print the variables in the current environment if
you  are running ReactOS in debug mode. Nice to have but not critical. I
dropped this part because it suffers from c++itis, a disease that forces
programmers to declare variables wherever they need them, even in C source
code. BTW, I am a professional Java, PHP, SQL, HTML, CSS, XML, XSLT programmer.
;-)

IMO, a better version of this snippet could look like this:
This part should be placed at the top of SmUpdateEnvironment.
+#ifndef NDEBUG
+    ULONG ii = 0;
+    PWSTR envp;
+#endif

This part should be placed at the end of SmUpdateEnvironment.
+#ifndef NDEBUG
+    DbgPrint("SmUpdateEnvironment:\n");
+    envp = SmSystemEnvironment;
+    while (*envp)
+    {
+        DbgPrint("  %u: %S\n", ii++, envp);
+        envp += wcslen(envp) + 1;
+    }
+#endif


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the Ros-bugs mailing list