[ros-bugs] [Bug 6648] PATCH: fix for kernel-mode/user-mode marshalling of WM_DDE_ACK

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=6648





--- Comment #3 from jimtabor <james.tabor at reactos.org>  2011-11-10 07:30:12 CET ---
(In reply to comment #0)
> 
> 2) Not part of the patch but maybe worth a second look:
> In subsystems/win32/win32k/ntuser/message.c there is this line:
> Message->QS_Flags = 0;
> The thing is, this field later gets overwritten by:
> Message->QS_Flags = QS_SENDMESSAGE;
> Is this an oversight?
> 
No, it is set by MsqWakeQueue.

> 3) Documentation is non-existent. I would have had to spend a lot less time on
> this if the original authors had annotated a bit, perhaps also discussing how
> all the functions juggle together. I still won't pretend to get what most of
> the code I've seen is for.
> 
> 4) We really need type-safe versions of the Windows header files. This whole
> problem wouldn't have happened if packed lParams and unpacked lParams would
> have been different types.
> 

Like I posted, it needs more love.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.