[ros-dev] rbuild feedback

[Casper Hornstrup]

> -----Original Message-----
> From: ros-dev-bounces at reactos.com [mailto:ros-dev-bounces at reactos.com] On Behalf Of Ge van Geldorp
> Sent: 23. april 2005 23:23
> To: 'ReactOS Development List'
> Subject: [ros-dev] rbuild feedback
> 
> > From: Royce Mitchell III
> >
> > Also, being this close, would everybody who cares please
> > check out the rbuild branch for feedback before we go live?
> 
> First, congratulations, I'm impressed by the work you and Casper have done.
> 
> I had one major problem (I need the *.nostrip.* files for GDB) which Casper
> solved within two hours after I mentioned it to him. Again very impressive,
> thanks.
> 

Thanks.

> There's two small issues, nice-to-have but not essential as far as I'm
> concerned. First is that used to be able to do "make" followed by "make
> install" from a subdirectory. The "make install" doesn't work anymore ("No
> rule to make target `install'.").

I'll fix that.

> The other thing is that I used to be able
> to setup a bootcd using "make bootcd", then I would go in, recompile
> something and copy it manually to ..\bootcd\disk\wherever. After that I
> could do a "make bootcd_makecd" so it would just use the files in
> ..\bootcd\disk to create the .iso, without having to go through the whole
> reactos tree. "make bootcd" is now one big target so that doesn't work
> anymore.

The issue here is wether or not to clean the bootcd directory before copying
the files into it. If we don't need to clean the directory first then we can
have 'make bootcd' copy the files using dependencies which will be quite fast
the second time since only the changed files will be copied. If we need to
clean the directory first then all files must always be copied into the bootcd
directory. The problem with not cleaning the directory first is that the
bootcd directory may be inconsistent due to bootcds made previously from other
revisions. 'make livecd' have the same issue. I could go either way so I'll
let you decide.

> I can probably fix both issues myself, but since you asked for feedback and
> I'm lazy...
> 
> Gé van Geldorp.