[ros-dev] Re: [ros-diffs] [ion] 18082: - Fix a bug in CSR Capture APIs

Thomas Weidenmueller w3seek at reactos.com
Mon Sep 26 13:24:35 CEST 2005


ion at svn.reactos.com wrote:
> +  CsrCaptureMessageBuffer(CaptureBuffer,
> +                          NULL,
> +                          Size,
> +                          (PVOID*)&Request.Data.PeekConsoleInputRequest.InputRecord);

The last parameter passed to CsrCaptureMessageBuffer in your changes
looks horribly wrong. The typecast hides the bug and shouldn't be
necessary, the compiler would've warned you that this is most likely wrong.

- Thomas


More information about the Ros-dev mailing list