[ros-dev] Re: [ros-svn] [gdalsnes] 18113: -reorder InsertXscendingOrder macro argument order and update uses

[Thomas Weidenmueller]

Gunnar Dalsnes wrote:
>>
>> Yeah it does, it should be expanded to properly show each step line by
>> line. 
> 
> 
> Thats your opinion. Seeing the boring internals of walking a list a
> billion times only pisses me off. I rather hide it where it cant be seen
> and focus on the usefull code instead.

Well, especially because it's the kernel, I agree with Alex. It shouln't
be hidden. I strongly prefer it the way it used to be.

>> Not macroized into a single unmaintainable ..thing.
> 
> 
> There really is no way of "maintaining" how to walk a list. This is
> pretty much established "science". That why a macro is nice, because i
> dont want you to see it nor maintain it (or comment on the basic
> operations of list walking);-P

Sometimes you want a loop to be slightly different. That's where the
macro fails. However, f.ex. inserting a list item or removing it is
_always_ the same, that's why there are macros for these and MS would've
defined such a macro if it was such a nice idea.

I can only reiterate, I'm never going to use these macros. At least not
in ntoskrnl or any drivers.

- Thomas