[ros-dev] Re:[ros-svn] [gdalsnes]18113:-reorderInsertXscendingOrdermacro argument order andupdate uses

Casper Hornstrup ch at csh-consult.dk
Wed Sep 28 18:56:15 CEST 2005



> -----Original Message-----
> From: ros-dev-bounces at reactos.com [mailto:ros-dev-bounces at reactos.com] On Behalf Of Thomas
> Weidenmueller
> Sent: 28. september 2005 18:15
> To: ReactOS Development List
> Subject: Re: [ros-dev] Re:[ros-svn] [gdalsnes]18113:-reorderInsertXscendingOrdermacro argument
> order andupdate uses
> 
> Casper Hornstrup wrote:
> > Oh please don't go there. Do you honestly think you (in general) are
> > smarter at generating microprocessor instructions than a multi-million hour
> > compiler software?
> In some places it does matter, especially in the kernel.

Prove it.

> 
> Splitting up a 200 lines functions in 10 helper functions IMO is ugly,
> especially when those helper functions are only used by that one single
> function. To avoid code duplication I *do* create helper functions, but
> most often only for things that can be shared with other code. I don't
> have problems with functions with a few hundreds of lines of code as
> long as the coding style is acceptable and it is sufficiently documented
> with comments.
> 
> However, we're going off topic...
> 
> - Thomas

Ok. I'll not argument against 200 line long functions then since it seems
I won't get anywhere.

Casper




More information about the Ros-dev mailing list