[ros-dev] Vote: code auditing
timo.kreuzer at web.de
Fri Feb 17 18:28:12 CET 2006
David Hinz schrieb:
> I think it's a bit complicated, as you have to mess around alot with
> different makefiles, but it _could_ work.
The makefiles are generated auttomatically. You just have to make sure
that the .rbuild files point to the right directories. So when moving a
folder to the new repository you will have to change all the .rbuild
files that point to that folder's .rbuild file. You could even write a
small tool, wich will do this, I think.
If everything is put into one new repository, you will have to edit alot
of rbuild files, too, because of the new structure.
> But the thing is, this actually is like locking all unaudited modules
> in trunk and let devs allow to change things in the audited modules.
> Your way is just a bit more complicated.
There wouldn't be the need of locking modules. If the devs vote to do
it, ok, if not, my idea would work, too. It just makes sure that audited
and unaudited code is seperated. And if devs are working on something in
the old repository, they will always be reminded, that they are actually
workng on unaudited code and might decide for themselves (if the modules
are not locked) to audit this before going on. And everyone can quickly
see, what has been audited and what not. It might help to get the audit
going, even without locking.
> I'm not an expert, so just wait for the devs' comments.
> David Hinz
Thanks for the comment. Looks like ROS life has a little moved from the
forums to the mailinglist ;-)
More information about the Ros-dev