[ros-dev] [ros-diffs] [ion] 24773: - MSVC VCPROJ Maker: * Don't insert NDEBUG as a define, files define this manually already. * Don't add _CRT flags, since the RTM WDK defines them properly. * Force warning.h to be i ncluded just like the WDK does. * Disable WP

[James Tabor]

Hi,
We need to stay current. WDK is free,, why not use it? Right?
Thanks,
James

Alex Ionescu wrote:
> Murphy, Ged (Bolton) wrote:
> 
>>ion at svn.reactos.org wrote:
>>
>>
>>
>>>- Please remember that you NEED the WDK 6000 RTM installed to 
>>>use MSVC for building ReactOS. Don't change global build 
>>>settings just because you were too lazy to download it and 
>>>think that because your Win32 app doesn't need it, it's ok to 
>>>break other people's native/system/kernel/hal builds. Change 
>>>it locally if you're lazy, but don't revert these changes again.
>>
>>
>>I highly dissagree that we should break building of usermode code in MSVC
>>just because someone doesn't have 1 header file which is included with the
>>WDK.
>>If it effects the building of HAL etc so much, then it should be a
>>requirement for those components only, not for wingui/win32dll code.
>>
>>Maybe including a similar header into our own code is a more viable option.
>>
>>Ged.
>
> 
> 
> It has nothing to do with the HAL. Building a Win32 program with the WDK
> also includes warning.h. There are more components in ReactOS that will
> require the WDK, the PSDK cannot be used. We have over 50 drivers that
> require it, as well as all the native components (another 10
> components), and the low-level Win32 libraries (ntdll, kernel32,
> advapi32, user32, gdi32, and probably some others).
>