[ros-dev] [ros-diffs] [dchapyshev] 37876: - Implement SetupInstallFileA/W - Stub implement SetupPromptForDiskA/W All from Wine.

Ged gedmurphy at gmail.com
Sat Dec 6 14:46:42 CET 2008


dchapyshev at svn.reactos.org wrote:
> +        if (!(inf_source = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) )))
> +        {
> +            SetLastError( ERROR_NOT_ENOUGH_MEMORY );
> +            return FALSE;
> +        }
> +        if (!SetupGetStringFieldW( inf_context, 1, inf_source, len, NULL )) return FALSE;
> +        source = inf_source;


There's a memory leak here. 
It's best to read Wine code when throughly, they have bugs too ;)

Ged.






More information about the Ros-dev mailing list