[ros-dev] [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord

[Timo Kreuzer]

Especially if the "fix" is no way better ;-)

gedmurphy schrieb:
> Why do you need to publically state it was broken and who broke it?
> Does it make you feel more important and help to boost your ego?
>
>
>
> -----Original Message-----
> From: ros-diffs-bounces at reactos.org [mailto:ros-diffs-bounces at reactos.org] On Behalf Of sginsberg at svn.reactos.org
> Sent: 16 October 2008 21:02
> To: ros-diffs at reactos.org
> Subject: [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord
>
> Author: sginsberg
> Date: Thu Oct 16 15:02:22 2008
> New Revision: 36773
>
> URL: http://svn.reactos.org/svn/reactos?rev=36773&view=rev
> Log:
> - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord
>
> Modified:
>     trunk/reactos/dll/win32/gdi32/objects/text.c
>
> Modified: trunk/reactos/dll/win32/gdi32/objects/text.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/objects/text.c?rev=36773&r1=36772&r2=36773&view=diff
> ==============================================================================
> --- trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] Thu Oct 16 15:02:22 2008
> @@ -358,20 +358,24 @@
>   * @implemented
>   */
>  INT
> -STDCALL
> +WINAPI
>  GetTextFaceW(HDC hDC,
> -             int nCount,
> -             LPWSTR	lpFaceName)
> -{
> -    INT retValue = 0;
> -    if ((!lpFaceName) || (nCount))
> -    {
> -        retValue = NtGdiGetTextFaceW(hDC,nCount,lpFaceName,0);
> +             INT nCount,
> +             PWSTR pFaceName)
> +{
> +    INT retValue;
> +
> +    if ((pFaceName && nCount) ||
> +        !(pFaceName && nCount))
> +    {
> +        retValue = NtGdiGetTextFaceW(hDC, nCount, pFaceName, 0);
>      }
>      else
>      {
>          SetLastError(ERROR_INVALID_PARAMETER);
> -    }
> +        retValue = 0;
> +    }
> +
>      return retValue;
>  }
>  
>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
>