[ros-dev] [ros-diffs] [jimtabor] 37099: Implement GetFontUnicodeRanges, port from wine. Tested with wine gdi32 font crosstests.

[James Tabor]

Hi!

On Thu, Oct 30, 2008 at 10:20 AM, Steven Edwards
<sedwards at bordeauxgroup.com> wrote:
> Hello,
>
> On Thu, Oct 30, 2008 at 9:33 AM,  <jimtabor at svn.reactos.org> wrote:
>> URL: http://svn.reactos.org/svn/reactos?rev=37099&view=rev
>> Log:
>> Implement GetFontUnicodeRanges, port from wine. Tested with wine gdi32 font crosstests.
>
> If your using enough of the original implementation to credit Wine
> then to me that means someone else at least partly own copyright to
> these functions. Could you please use git blame or git web and see who
> the author was of the original implementation from Wine and credit
> them appropriately in the header? From time to time when someone says
> 'foo from wine' I get pinged from wine developers who's code is
> appropriated and they ask for proper attribution. If we don't do it
> right the first time, then at some point another audit of each commit
> from SVN will have to happen and we will have to go back and add those
> copyright holders to the files license header.
>
> --
> Steven Edwards
I guess the operative word is "Port" that means rewrite of the
original code. Any moron can go back and compare the code and see
where it came from. I did add a comment that it was a port from wine.
With the next cycle in the mix I will commit the proper header for the
file.

Using the word "audit" could get you kicked from the project, we
consider that word to be inappropriate and vulgar. This word is used
to create panic and distrust in FOSS protects This type of fear
mongering has been known to kill development in projects like ReactOS.
Please do not use this word in conversation or in written form. When
coming in contact of this word, sacrifice two live chickens and one
whole male goat before the next full moon. This will assure a good
cleansing and keep code weevils from breaking in on the morning of the
full moon. Apply a ring of salt around your personal computer space
and make sure there are no broken lines. Once all these
countermeasures are in place you can rest assure that no code weevils
can harm you.

Thanks,
James