[ros-dev] [ros-diffs] [dchapyshev] 53513: - Fix wrong macros usage, found by PVS-Studio

Thomas Faber thfabba at gmx.de
Thu Sep 1 12:48:23 UTC 2011


Hi,

On 2011-09-01 14:34, dchapyshev at svn.reactos.org wrote:
> --- trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] (original)
> +++ trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] Thu Sep  1 12:34:51 2011
> @@ -339,7 +339,7 @@
>      }
>  
>      /* Set all full ULONGs */
> -    RtlFillMemoryUlong(Buffer, NumberToSet >> 3, MAXULONG);
> +    RtlFillMemoryUlong(Buffer, MAXULONG, NumberToSet >> 3);
>      Buffer += NumberToSet >> 5;
>  
>      /* Set what's left */
> 
> 

This is wrong. We don't want to fill 4GB of memory :)

Regards,
Tom



More information about the Ros-dev mailing list