[ros-diffs] [arty] 12741: Change temporary file creation to tmpfile(). FullName was not initialized

arty at svn.reactos.com arty at svn.reactos.com
Mon Jan 3 00:46:30 CET 2005


Change temporary file creation to tmpfile().  FullName was not
initialized
correctly before and it's only by chance that this worked at all.
Modified: trunk/reactos/tools/cabman/cabinet.cxx
  _____  

Modified: trunk/reactos/tools/cabman/cabinet.cxx
--- trunk/reactos/tools/cabman/cabinet.cxx	2005-01-02 23:12:40 UTC
(rev 12740)
+++ trunk/reactos/tools/cabman/cabinet.cxx	2005-01-02 23:46:28 UTC
(rev 12741)
@@ -188,7 +188,7 @@

         return CAB_STATUS_FAILURE;
 #else /* !WIN32 */
     fclose(FileHandle);
-    FileHandle = fopen(FullName, "w+b"); 
+    FileHandle = tmpfile();
     if (FileHandle == NULL) {
         DPRINT(MID_TRACE, ("ERROR '%d'.\n", (unsigned int)errno));
         return CAB_STATUS_FAILURE;
@@ -532,6 +532,7 @@
         return false;
     }
 #else /* !WIN32 */
+    
     FileHandle = fopen(ConvertPath(FileName, true), "rb"); 
     if (FileHandle == NULL) {
         DPRINT(MID_TRACE, ("Cannot open cabinet reserved file.\n"));
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.reactos.org/pipermail/ros-diffs/attachments/20050103/9b3f9b3c/attachment.html


More information about the Ros-diffs mailing list