[ros-diffs] [fireball] 23524: Force -fno-sibling-call-optimisation to every module's CFLAGs. This fixes *numerous* bugs (thanks to a bug in GCC itself), even in DBG=1 builds! Just an example, comctl32.dll doesn't crash anymore in LISTVIEW_Callback(). Thanks to Dmitriy Philippov (aka Shedon) for encountering the comctl32 bug and investigating it!

[fireball at svn.reactos.org]

Author: fireball
Date: Tue Aug  8 16:41:56 2006
New Revision: 23524

URL: http://svn.reactos.org/svn/reactos?rev=23524&view=rev
Log:
Force -fno-sibling-call-optimisation to every module's CFLAGs. This fixes *numerous* bugs (thanks to a bug in GCC itself), even in DBG=1 builds!

Just an example, comctl32.dll doesn't crash anymore in LISTVIEW_Callback().

Thanks to Dmitriy Philippov (aka Shedon) for encountering the comctl32 bug and investigating it!

Modified:
    trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp

Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp?rev=23524&r1=23523&r2=23524&view=diff
==============================================================================
--- trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp (original)
+++ trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp Tue Aug  8 16:41:56 2006
@@ -1885,6 +1885,10 @@
 		globalCflags += " -pipe";
 	if ( !module.allowWarnings )
 		globalCflags += " -Werror";
+
+	// Always force disabling of sibling calls optimisation for GCC
+	// (TODO: Move to version-specific once this bug is fixed in GCC)
+	globalCflags += " -fno-optimize-sibling-calls";
 	
 	fprintf (
 		fMakefile,