[ros-diffs] [greatlrd] 23166: small cleanup of the code in this file. and alot of callbacks working as they should if a drv support it.

[greatlrd at svn.reactos.org]

Author: greatlrd
Date: Wed Jul 19 05:49:55 2006
New Revision: 23166

URL: http://svn.reactos.org/svn/reactos?rev=23166&view=rev
Log:
small cleanup of the code in this file. 
and alot of callbacks working as they should if a drv support it.

Modified:
    trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c

Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c?rev=23166&r1=23165&r2=23166&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c (original)
+++ trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c Wed Jul 19 05:49:55 2006
@@ -264,7 +264,6 @@
 	   RtlMoveMemory(puD3dCallbacks, pHalInfo->lpD3DHALCallbacks, sizeof( D3DNTHAL_CALLBACKS ) );		
 	}
 
-
 	if (pHalInfo->lpD3DBufCallbacks)
     {
        DPRINT1("Found DirectDraw CallBack for 3D Hal Bufffer  \n");                                
@@ -370,34 +369,28 @@
     PDD_WAITFORVERTICALBLANKDATA puWaitForVerticalBlankData
 )
 {
-	DWORD  ddRVal;
+	DWORD  ddRVal = DDHAL_DRIVER_NOTHANDLED;
 	PDD_DIRECTDRAW_GLOBAL lgpl;
     PDD_DIRECTDRAW pDirectDraw;
-#ifdef DX_DEBUG
+
 	DPRINT1("NtGdiDdWaitForVerticalBlank\n");
-#endif
-
 
 	pDirectDraw = GDIOBJ_LockObj(DdHandleTable, hDirectDrawLocal, GDI_OBJECT_TYPE_DIRECTDRAW);
-	if (pDirectDraw == NULL) 
-		return DDHAL_DRIVER_NOTHANDLED;
-
-	/* backup the orignal PDev and info */
-	lgpl = puWaitForVerticalBlankData->lpDD;
-
-	/* use our cache version instead */
-	puWaitForVerticalBlankData->lpDD = &pDirectDraw->Global;
-
-	/* make the call */
-	if (!(pDirectDraw->DD.dwFlags & DDHAL_CB32_WAITFORVERTICALBLANK))
-		ddRVal = DDHAL_DRIVER_NOTHANDLED;
-	else	
-  	    ddRVal = pDirectDraw->DD.WaitForVerticalBlank(puWaitForVerticalBlankData);
-
-	/* But back the orignal PDev */
-	puWaitForVerticalBlankData->lpDD = lgpl;
-
-    GDIOBJ_UnlockObjByPtr(DdHandleTable, pDirectDraw);
+	
+	if (pDirectDraw != NULL) 
+	{	
+		if (pDirectDraw->DD.dwFlags & DDHAL_CB32_WAITFORVERTICALBLANK)
+		{
+			lgpl = puWaitForVerticalBlankData->lpDD;	
+			puWaitForVerticalBlankData->lpDD = &pDirectDraw->Global;        	
+
+  	        ddRVal = pDirectDraw->DD.WaitForVerticalBlank(puWaitForVerticalBlankData);
+	
+	        puWaitForVerticalBlankData->lpDD = lgpl;            
+	     }
+		 GDIOBJ_UnlockObjByPtr(DdHandleTable, pDirectDraw);
+	}
+
 	return ddRVal;
 }
 
@@ -406,33 +399,33 @@
     PDD_CANCREATESURFACEDATA puCanCreateSurfaceData
 )
 {
-	DWORD  ddRVal;
+	DWORD  ddRVal = DDHAL_DRIVER_NOTHANDLED;
 	PDD_DIRECTDRAW_GLOBAL lgpl;	
 
 	PDD_DIRECTDRAW pDirectDraw = GDIOBJ_LockObj(DdHandleTable, hDirectDrawLocal, GDI_OBJECT_TYPE_DIRECTDRAW);
-#ifdef DX_DEBUG
+
 	DPRINT1("NtGdiDdCanCreateSurface\n");
-#endif
-	if (pDirectDraw == NULL) 
-		return DDHAL_DRIVER_NOTHANDLED;
-
-	/* backup the orignal PDev and info */
-	lgpl = puCanCreateSurfaceData->lpDD;
-
-	/* use our cache version instead */
-	puCanCreateSurfaceData->lpDD = &pDirectDraw->Global;
-
-	/* make the call */
-	if (!(pDirectDraw->DD.dwFlags & DDHAL_CB32_CANCREATESURFACE))
-		ddRVal = DDHAL_DRIVER_NOTHANDLED;
-	else	
-	    ddRVal = pDirectDraw->DD.CanCreateSurface(puCanCreateSurfaceData);
-
-	/* But back the orignal PDev */
-	puCanCreateSurfaceData->lpDD = lgpl;
+
+	if (pDirectDraw == NULL) 
+		return DDHAL_DRIVER_NOTHANDLED;
+
+	if (pDirectDraw != NULL)
+	{
+
+		if (pDirectDraw->DD.dwFlags & DDHAL_CB32_CANCREATESURFACE)
+		{	
+			lgpl = puCanCreateSurfaceData->lpDD;	
+			puCanCreateSurfaceData->lpDD = &pDirectDraw->Global;
+
+	        ddRVal = pDirectDraw->DD.CanCreateSurface(puCanCreateSurfaceData);	
+
+	        puCanCreateSurfaceData->lpDD = lgpl;
+		}
 
 	GDIOBJ_UnlockObjByPtr(DdHandleTable, pDirectDraw);
-	return ddRVal;
+	}
+
+  return ddRVal;
 }
 
 DWORD STDCALL NtGdiDdGetScanLine(
@@ -440,33 +433,29 @@
     PDD_GETSCANLINEDATA puGetScanLineData
 )
 {
-	DWORD  ddRVal;
+	DWORD  ddRVal = DDHAL_DRIVER_NOTHANDLED;
 	PDD_DIRECTDRAW_GLOBAL lgpl;
 
 	PDD_DIRECTDRAW pDirectDraw = GDIOBJ_LockObj(DdHandleTable, hDirectDrawLocal, GDI_OBJECT_TYPE_DIRECTDRAW);
-#ifdef DX_DEBUG
+
 	DPRINT1("NtGdiDdGetScanLine\n");
-#endif
-	if (pDirectDraw == NULL) 
-		return DDHAL_DRIVER_NOTHANDLED;
-
-	/* backup the orignal PDev and info */
-	lgpl = puGetScanLineData->lpDD;
-
-	/* use our cache version instead */
-	puGetScanLineData->lpDD = &pDirectDraw->Global;
-
-	/* make the call */
-	if (!(pDirectDraw->DD.dwFlags & DDHAL_CB32_GETSCANLINE))
-		ddRVal = DDHAL_DRIVER_NOTHANDLED;
-	else	
-	    ddRVal = pDirectDraw->DD.GetScanLine(puGetScanLineData);
-
-	/* But back the orignal PDev */
-	puGetScanLineData->lpDD = lgpl;
-
-	GDIOBJ_UnlockObjByPtr(DdHandleTable, pDirectDraw);
-	return ddRVal;
+
+	if (pDirectDraw != NULL) 
+	{
+		if (pDirectDraw->DD.dwFlags & DDHAL_CB32_GETSCANLINE)
+		{
+			lgpl = puGetScanLineData->lpDD;	
+			puGetScanLineData->lpDD = &pDirectDraw->Global;
+	
+	        ddRVal = pDirectDraw->DD.GetScanLine(puGetScanLineData);
+	
+	        puGetScanLineData->lpDD = lgpl;
+		}
+
+	    GDIOBJ_UnlockObjByPtr(DdHandleTable, pDirectDraw);
+	}
+
+   return ddRVal;
 }