[ros-diffs] [cfinck] 29143: Call ShellExecute with NULL instead of "open", so the default action is used, when a file name does not support "open". (see http://msdn2.microsoft.com/en-us/library/ms647732.aspx) According to someone in the bug report, this is the behaviour used under Windows XP. See issue #1461 for more details.

cfinck at svn.reactos.org cfinck at svn.reactos.org
Sat Sep 22 18:52:54 CEST 2007


Author: cfinck
Date: Sat Sep 22 20:52:53 2007
New Revision: 29143

URL: http://svn.reactos.org/svn/reactos?rev=29143&view=rev
Log:
Call ShellExecute with NULL instead of "open", so the default action is used, when a file name does not support "open". (see http://msdn2.microsoft.com/en-us/library/ms647732.aspx)
According to someone in the bug report, this is the behaviour used under Windows XP.
See issue #1461 for more details.

Modified:
    trunk/reactos/dll/win32/shell32/dialogs.c

Modified: trunk/reactos/dll/win32/shell32/dialogs.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/dialogs.c?rev=29143&r1=29142&r2=29143&view=diff
==============================================================================
--- trunk/reactos/dll/win32/shell32/dialogs.c (original)
+++ trunk/reactos/dll/win32/shell32/dialogs.c Sat Sep 22 20:52:53 2007
@@ -145,7 +145,7 @@
                         psz = HeapAlloc( GetProcessHeap(), 0, (ic + 2) );
                         GetWindowTextA (htxt, psz, ic + 1) ;
 
-                        if (ShellExecuteA(NULL, "open", psz, NULL, NULL, SW_SHOWNORMAL) < (HINSTANCE)33)
+                        if (ShellExecuteA(NULL, NULL, psz, NULL, NULL, SW_SHOWNORMAL) < (HINSTANCE)33)
                             {
                             char *pszSysMsg = NULL ;
                             FormatMessageA (




More information about the Ros-diffs mailing list