[ros-diffs] [jmorlan] 35649: cmd_set: - When given a name with no value, show all variables that start with that name. - Implement /P switch - Set nErrorLevel on failure - Make syntax more compatible with Windows (allow any control character to act as space; implement quoting)

[jmorlan at svn.reactos.org]

Author: jmorlan
Date: Mon Aug 25 18:48:18 2008
New Revision: 35649

URL: http://svn.reactos.org/svn/reactos?rev=35649&view=rev
Log:
cmd_set:
- When given a name with no value, show all variables that start with that name.
- Implement /P switch
- Set nErrorLevel on failure
- Make syntax more compatible with Windows (allow any control character to act as space; implement quoting)

Modified:
    trunk/reactos/base/shell/cmd/set.c

Modified: trunk/reactos/base/shell/cmd/set.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/set.c?rev=35649&r1=35648&r2=35649&view=diff
==============================================================================
--- trunk/reactos/base/shell/cmd/set.c [iso-8859-1] (original)
+++ trunk/reactos/base/shell/cmd/set.c [iso-8859-1] Mon Aug 25 18:48:18 2008
@@ -48,12 +48,33 @@
 static LPCTSTR
 skip_ws ( LPCTSTR p )
 {
-	return p + _tcsspn ( p, _T(" \t") );
+	while (*p && *p <= _T(' '))
+		p++;
+	return p;
+}
+
+/* Used to check for and handle:
+ * SET "var=value", SET /P "var=prompt", and SET /P var="prompt" */
+static LPTSTR
+GetQuotedString(TCHAR *p)
+{
+	TCHAR *end;
+	if (*p == _T('"'))
+	{
+		p = (LPTSTR)skip_ws(p + 1);
+		/* If a matching quote is found, truncate the string */
+		end = _tcsrchr(p, _T('"'));
+		if (end)
+			*end = _T('\0');
+	}
+	return p;
 }
 
 INT cmd_set (LPTSTR param)
 {
 	LPTSTR p;
+	LPTSTR lpEnv;
+	LPTSTR lpOutput;
 
 	if ( !_tcsncmp (param, _T("/?"), 2) )
 	{
@@ -61,26 +82,20 @@
 		return 0;
 	}
 
+	param = (LPTSTR)skip_ws(param);
+
 	/* if no parameters, show the environment */
 	if (param[0] == _T('\0'))
 	{
-		LPTSTR lpEnv;
-		LPTSTR lpOutput;
-		INT len;
-
 		lpEnv = (LPTSTR)GetEnvironmentStrings ();
 		if (lpEnv)
 		{
 			lpOutput = lpEnv;
 			while (*lpOutput)
 			{
-				len = _tcslen(lpOutput);
-				if (len)
-				{
-					if (*lpOutput != _T('='))
-						ConOutPuts (lpOutput);
-					lpOutput += (len + 1);
-				}
+				if (*lpOutput != _T('='))
+					ConOutPuts(lpOutput);
+				lpOutput += _tcslen(lpOutput) + 1;
 			}
 			FreeEnvironmentStrings (lpEnv);
 		}
@@ -97,15 +112,34 @@
 			/*might seem random but this is what windows xp does */
 			nErrorLevel = 9165;
 		}
-		/* TODO FIXME - what are we supposed to return? */
-		return Success;
-	}
-
-	if ( !_tcsnicmp (param, _T("/"), 1) )
-	{
-		ConErrResPrintf (STRING_SYNTAX_COMMAND_INCORRECT, param);
+		return !Success;
+	}
+
+	if (!_tcsnicmp(param, _T("/P"), 2))
+	{
+		TCHAR value[1023];
+		param = GetQuotedString((LPTSTR)skip_ws(param + 2));
+		p = _tcschr(param, _T('='));
+		if (!p)
+		{
+			ConErrResPuts(STRING_SYNTAX_COMMAND_INCORRECT);
+			nErrorLevel = 1;
+			return 1;
+		}
+
+		*p++ = _T('\0');
+		ConOutPrintf(_T("%s"), GetQuotedString(p));
+		ConInString(value, 1023);
+
+		if (!*value || !SetEnvironmentVariable(param, value))
+		{
+			nErrorLevel = 1;
+			return 1;
+		}
 		return 0;
 	}
+
+	param = GetQuotedString(param);
 
 	p = _tcschr (param, _T('='));
 	if (p)
@@ -114,41 +148,53 @@
 		if (p == param)
 		{
 			/* handle set =val case */
-			ConErrResPrintf (STRING_SYNTAX_COMMAND_INCORRECT, param);
-			return 0;
-		}
-
+			ConErrResPuts(STRING_SYNTAX_COMMAND_INCORRECT);
+			nErrorLevel = 1;
+			return 1;
+		}
+
+		*p++ = _T('\0');
+		if (!SetEnvironmentVariable(param, p))
+		{
+			nErrorLevel = 1;
+			return 1;
+		}
+	}
+	else
+	{
+		/* display all environment variable with the given prefix */
+		BOOL bFound = FALSE;
+
+		while (_istspace(*param) || *param == _T(',') || *param == _T(';'))
+			param++;
+
+		p = _tcsrchr(param, _T(' '));
+		if (!p)
+			p = param + _tcslen(param);
 		*p = _T('\0');
-		p++;
-		if (*p == _T('\0'))
-		{
-			p = NULL;
-		}
-		SetEnvironmentVariable (param, p);
-	}
-	else
-	{
-		/* display environment variable */
-		LPTSTR pszBuffer;
-		DWORD dwBuffer;
-
-		pszBuffer = (LPTSTR)cmd_alloc (ENV_BUFFER_SIZE * sizeof(TCHAR));
-		dwBuffer = GetEnvironmentVariable (param, pszBuffer, ENV_BUFFER_SIZE);
-		if (dwBuffer == 0)
+
+		lpEnv = GetEnvironmentStrings();
+		if (lpEnv)
+		{
+			lpOutput = lpEnv;
+			while (*lpOutput)
+			{
+				if (!_tcsnicmp(lpOutput, param, p - param))
+				{
+					ConOutPuts(lpOutput);
+					bFound = TRUE;
+				}
+				lpOutput += _tcslen(lpOutput) + 1;
+			}
+			FreeEnvironmentStrings(lpEnv);
+		}
+
+		if (!bFound)
 		{
 			ConErrResPrintf (STRING_PATH_ERROR, param);
-			return 0;
-		}
-		else if (dwBuffer > ENV_BUFFER_SIZE)
-		{
-			pszBuffer = (LPTSTR)cmd_realloc (pszBuffer, dwBuffer * sizeof (TCHAR));
-			GetEnvironmentVariable (param, pszBuffer, dwBuffer);
-		}
-		ConOutPrintf (_T("%s\n"), pszBuffer);
-
-		cmd_free (pszBuffer);
-
-		return 0;
+			nErrorLevel = 1;
+			return 1;
+		}
 	}
 
 	return 0;