[ros-diffs] [cfinck] 34414: Warning fixes for devenum by Stefan Ginsberg
cfinck at svn.reactos.org
cfinck at svn.reactos.org
Thu Jul 10 18:26:28 CEST 2008
- Previous message: [ros-diffs] [jmorlan] 34413: Some fixes for console alias functions: - Pass buffers via a CSR capture buffer, instead of trying to cram them in the size-limited LPC message. - GetConsoleAliasW: Return number of bytes written, not unrelated "Size" variable. - GetConsoleAliasExesW: Return value is in bytes, not characters. - GetConsoleAliasA, GetConsoleAliasExesA: Parameters and returns of corresponding W functions are in bytes, not characters. - IntFindAliasHeader, IntGetAliasEntry: Break when current name is greater, not less. - IntCreateAliasHeader: Fix bad use of pointer arithmetic; initialize Data to NULL. - IntCreateAliasEntry: Fix bad use of pointer arithmetic. - IntGetConsoleAliasesExesLength: Fix infinite loop; add sizeof(WCHAR) instead of 1. - IntGetAllConsoleAliasesLength: Fix infinite loop. - CsrGetConsoleAlias, CsrGetAllConsoleAliases, CsrGetConsoleAliasesExes: Don't use a winerror where an NTSTATUS is needed.
- Next message: [ros-diffs] [tkreuzer] 34415: Patch by Stefan Ginsberg: fix members of UNIVERSAL_FONT_ID, based on msdn
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: cfinck
Date: Thu Jul 10 11:26:28 2008
New Revision: 34414
URL: http://svn.reactos.org/svn/reactos?rev=34414&view=rev
Log:
Warning fixes for devenum by Stefan Ginsberg
Modified:
trunk/reactos/dll/directx/devenum/devenum.rbuild
trunk/reactos/dll/directx/devenum/devenum_private.h
trunk/reactos/dll/directx/devenum/mediacatenum.c
Modified: trunk/reactos/dll/directx/devenum/devenum.rbuild
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/devenum/devenum.rbuild?rev=34414&r1=34413&r2=34414&view=diff
==============================================================================
--- trunk/reactos/dll/directx/devenum/devenum.rbuild [iso-8859-1] (original)
+++ trunk/reactos/dll/directx/devenum/devenum.rbuild [iso-8859-1] Thu Jul 10 11:26:28 2008
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd">
-<module name="devenum" type="win32dll" baseaddress="${BASEADDRESS_DEVENUM}" installbase="system32" installname="devenum.dll" allowwarnings="true" unicode="yes">
+<module name="devenum" type="win32dll" baseaddress="${BASEADDRESS_DEVENUM}" installbase="system32" installname="devenum.dll" unicode="yes">
<!-- Won't load correctly in ReactOS yet autoregister infsection="OleControlDlls" type="DllRegisterServer" -->
<importlibrary definition="devenum.spec.def" />
<include base="devenum">.</include>
Modified: trunk/reactos/dll/directx/devenum/devenum_private.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/devenum/devenum_private.h?rev=34414&r1=34413&r2=34414&view=diff
==============================================================================
--- trunk/reactos/dll/directx/devenum/devenum_private.h [iso-8859-1] (original)
+++ trunk/reactos/dll/directx/devenum/devenum_private.h [iso-8859-1] Thu Jul 10 11:26:28 2008
@@ -67,7 +67,7 @@
typedef struct
{
IEnumMonikerVtbl *lpVtbl;
- DWORD ref;
+ LONG ref;
DWORD index;
HKEY hkey;
} EnumMonikerImpl;
@@ -76,7 +76,7 @@
{
IMonikerVtbl *lpVtbl;
- ULONG ref;
+ LONG ref;
HKEY hkey;
} MediaCatMoniker;
Modified: trunk/reactos/dll/directx/devenum/mediacatenum.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/devenum/mediacatenum.c?rev=34414&r1=34413&r2=34414&view=diff
==============================================================================
--- trunk/reactos/dll/directx/devenum/mediacatenum.c [iso-8859-1] (original)
+++ trunk/reactos/dll/directx/devenum/mediacatenum.c [iso-8859-1] Thu Jul 10 11:26:28 2008
@@ -40,7 +40,7 @@
typedef struct
{
IPropertyBagVtbl *lpVtbl;
- DWORD ref;
+ LONG ref;
HKEY hkey;
} RegPropBagImpl;
@@ -103,7 +103,7 @@
IErrorLog* pErrorLog)
{
LPVOID pData = NULL;
- LONG received;
+ DWORD received;
DWORD type = 0;
RegPropBagImpl *This = (RegPropBagImpl *)iface;
HRESULT res = S_OK;
- Previous message: [ros-diffs] [jmorlan] 34413: Some fixes for console alias functions: - Pass buffers via a CSR capture buffer, instead of trying to cram them in the size-limited LPC message. - GetConsoleAliasW: Return number of bytes written, not unrelated "Size" variable. - GetConsoleAliasExesW: Return value is in bytes, not characters. - GetConsoleAliasA, GetConsoleAliasExesA: Parameters and returns of corresponding W functions are in bytes, not characters. - IntFindAliasHeader, IntGetAliasEntry: Break when current name is greater, not less. - IntCreateAliasHeader: Fix bad use of pointer arithmetic; initialize Data to NULL. - IntCreateAliasEntry: Fix bad use of pointer arithmetic. - IntGetConsoleAliasesExesLength: Fix infinite loop; add sizeof(WCHAR) instead of 1. - IntGetAllConsoleAliasesLength: Fix infinite loop. - CsrGetConsoleAlias, CsrGetAllConsoleAliases, CsrGetConsoleAliasesExes: Don't use a winerror where an NTSTATUS is needed.
- Next message: [ros-diffs] [tkreuzer] 34415: Patch by Stefan Ginsberg: fix members of UNIVERSAL_FONT_ID, based on msdn
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list