[ros-diffs] [gschneider] 37169: - Several ExFreePool -> ExFreePoolWithTag changes (local allocations) - Tested for ~2 weeks now, no BAD_POOL_CALLER's so far
gschneider at svn.reactos.org
gschneider at svn.reactos.org
Mon Nov 3 14:26:05 CET 2008
Author: gschneider
Date: Mon Nov 3 07:26:03 2008
New Revision: 37169
URL: http://svn.reactos.org/svn/reactos?rev=37169&view=rev
Log:
- Several ExFreePool -> ExFreePoolWithTag changes (local allocations)
- Tested for ~2 weeks now, no BAD_POOL_CALLER's so far
Modified:
trunk/reactos/subsystems/win32/win32k/eng/event.c
trunk/reactos/subsystems/win32/win32k/eng/semaphor.c
trunk/reactos/subsystems/win32/win32k/ntuser/accelerator.c
trunk/reactos/subsystems/win32/win32k/ntuser/caret.c
trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c
trunk/reactos/subsystems/win32/win32k/objects/bitblt.c
trunk/reactos/subsystems/win32/win32k/objects/coord.c
trunk/reactos/subsystems/win32/win32k/objects/pen.c
Modified: trunk/reactos/subsystems/win32/win32k/eng/event.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/eng/event.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/eng/event.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/eng/event.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -56,7 +56,7 @@
NULL);
if (!NT_SUCCESS(Status))
{
- ExFreePool(Event);
+ ExFreePoolWithTag(Event, TAG_DFSM);
return NULL;
}
else
Modified: trunk/reactos/subsystems/win32/win32k/eng/semaphor.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/eng/semaphor.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/eng/semaphor.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/eng/semaphor.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -16,7 +16,7 @@
return NULL;
if ( !NT_SUCCESS(ExInitializeResourceLite ( psem )) )
{
- ExFreePool ( psem );
+ ExFreePoolWithTag ( psem, TAG_GSEM );
return NULL;
}
return (HSEMAPHORE)psem;
Modified: trunk/reactos/subsystems/win32/win32k/ntuser/accelerator.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/accelerator.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/accelerator.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/accelerator.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -371,7 +371,7 @@
Status = MmCopyFromCaller(Accel->Table, Entries, EntriesCount * sizeof(ACCEL));
if (!NT_SUCCESS(Status))
{
- ExFreePool(Accel->Table);
+ ExFreePoolWithTag(Accel->Table, TAG_ACCEL);
UserDereferenceObject(Accel);
UserDeleteObject(hAccel, otAccel);
SetLastNtError(Status);
Modified: trunk/reactos/subsystems/win32/win32k/ntuser/caret.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/caret.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/caret.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/caret.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -123,7 +123,7 @@
if(!NT_SUCCESS(Status) || (KeyValuePartialInfo->Type != REG_SZ))
{
NtClose(KeyHandle);
- ExFreePool(KeyValuePartialInfo);
+ ExFreePoolWithTag(KeyValuePartialInfo, TAG_STRING);
return 0;
}
@@ -137,7 +137,7 @@
Val = 0;
}
- ExFreePool(KeyValuePartialInfo);
+ ExFreePoolWithTag(KeyValuePartialInfo, TAG_STRING);
NtClose(KeyHandle);
return (UINT)Val;
Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -1259,7 +1259,7 @@
FALSE, &Context, NULL))
{
/* Something went wrong, maybe someone added a directory entry? Just give up. */
- ExFreePool(Buffer);
+ ExFreePoolWithTag(Buffer, TAG_WINSTA);
ObDereferenceObject(DirectoryHandle);
return NT_SUCCESS(Status) ? STATUS_INTERNAL_ERROR : Status;
}
@@ -1287,7 +1287,7 @@
{
if (Buffer != InitialBuffer)
{
- ExFreePool(Buffer);
+ ExFreePoolWithTag(Buffer, TAG_WINSTA);
}
return STATUS_BUFFER_TOO_SMALL;
}
@@ -1300,7 +1300,7 @@
{
if (Buffer != InitialBuffer)
{
- ExFreePool(Buffer);
+ ExFreePoolWithTag(Buffer, TAG_WINSTA);
}
return STATUS_BUFFER_TOO_SMALL;
}
Modified: trunk/reactos/subsystems/win32/win32k/objects/bitblt.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/objects/bitblt.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -1143,7 +1143,7 @@
if (!NT_SUCCESS(Status))
{
- ExFreePool(rb);
+ ExFreePoolWithTag(rb, TAG_PATBLT);
SetLastNtError(Status);
return FALSE;
}
@@ -1152,7 +1152,7 @@
Ret = IntGdiPolyPatBlt(hDC, dwRop, rb, cRects, Mode);
if (cRects > 0)
- ExFreePool(rb);
+ ExFreePoolWithTag(rb, TAG_PATBLT);
return Ret;
}
Modified: trunk/reactos/subsystems/win32/win32k/objects/coord.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/objects/coord.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/coord.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/coord.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -285,7 +285,7 @@
if(!NT_SUCCESS(Status))
{
DC_UnlockDc(dc);
- ExFreePool(Points);
+ ExFreePoolWithTag(Points, TAG_COORD);
SetLastNtError(Status);
return FALSE;
}
@@ -302,7 +302,7 @@
default:
{
DC_UnlockDc(dc);
- ExFreePool(Points);
+ ExFreePoolWithTag(Points, TAG_COORD);
SetLastWin32Error(ERROR_INVALID_PARAMETER);
return FALSE;
}
@@ -324,7 +324,7 @@
if(!NT_SUCCESS(Status))
{
DC_UnlockDc(dc);
- ExFreePool(Points);
+ ExFreePoolWithTag(Points, TAG_COORD);
SetLastNtError(Status);
return FALSE;
}
@@ -332,7 +332,7 @@
// If we are getting called that means User XForms is a mess!
//
DC_UnlockDc(dc);
- ExFreePool(Points);
+ ExFreePoolWithTag(Points, TAG_COORD);
return TRUE;
}
Modified: trunk/reactos/subsystems/win32/win32k/objects/pen.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/objects/pen.c?rev=37169&r1=37168&r2=37169&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/pen.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/pen.c [iso-8859-1] Mon Nov 3 07:26:03 2008
@@ -323,7 +323,7 @@
if(!NT_SUCCESS(Status))
{
SetLastNtError(Status);
- ExFreePool(pSafeStyle);
+ ExFreePoolWithTag(pSafeStyle, TAG_PENSTYLES);
return 0;
}
}
@@ -341,7 +341,7 @@
hBrush);
if (!hPen && pSafeStyle)
{
- ExFreePool(pSafeStyle);
+ ExFreePoolWithTag(pSafeStyle, TAG_PENSTYLES);
}
return hPen;
}
More information about the Ros-diffs
mailing list