[ros-diffs] [sginsberg] 37358: - Don't define PAGE_SIZE in typedefs.h as -- "this value is target specific, host tools MUST not use it and this line has to be removed". Instead, define it locally for cmlib. - Also correct TRUE definition in this header

[sginsberg at svn.reactos.org]

Author: sginsberg
Date: Fri Nov 14 08:49:11 2008
New Revision: 37358

URL: http://svn.reactos.org/svn/reactos?rev=37358&view=rev
Log:
- Don't define PAGE_SIZE in typedefs.h as -- "this value is target specific, host tools MUST not use it and this line has to be removed". Instead, define it locally for cmlib.
- Also correct TRUE definition in this header

Modified:
    trunk/reactos/include/host/typedefs.h
    trunk/reactos/lib/cmlib/cmlib.h

Modified: trunk/reactos/include/host/typedefs.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/host/typedefs.h?rev=37358&r1=37357&r2=37358&view=diff
==============================================================================
--- trunk/reactos/include/host/typedefs.h [iso-8859-1] (original)
+++ trunk/reactos/include/host/typedefs.h [iso-8859-1] Fri Nov 14 08:49:11 2008
@@ -40,11 +40,7 @@
 #define OPTIONAL
 
 #define FALSE 0
-#define TRUE (!(FALSE))
-
-/* FIXME: this value is target specific, host tools MUST not use it
- * and this line has to be removed */
-#define PAGE_SIZE 4096
+#define TRUE  1
 
 #define ANYSIZE_ARRAY 1
 

Modified: trunk/reactos/lib/cmlib/cmlib.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmlib.h?rev=37358&r1=37357&r2=37358&view=diff
==============================================================================
--- trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] (original)
+++ trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] Fri Nov 14 08:49:11 2008
@@ -101,6 +101,21 @@
 #ifndef ROUND_UP
 #define ROUND_UP(a,b)        ((((a)+(b)-1)/(b))*(b))
 #define ROUND_DOWN(a,b)      (((a)/(b))*(b))
+#endif
+
+//
+// PAGE_SIZE definition
+//
+#ifndef PAGE_SIZE
+#if defined(_M_IX86)
+#define PAGE_SIZE 0x1000
+#elif defined(_M_AMD64)
+#define PAGE_SIZE 0x1000
+#elif defined(_M_ARM)
+#define PAGE_SIZE 0x1000
+#else
+#error Local PAGE_SIZE definition required
+#endif
 #endif
 
 #define TAG_CM 0x68742020