[ros-diffs] [fireball] 36660: Dmitry Gorbachev - Fix 'overflow in implicit constant conversion' warnings (treated as errors). See issue #3759 for more details.

fireball at svn.reactos.org fireball at svn.reactos.org
Mon Oct 6 12:12:27 CEST 2008


Author: fireball
Date: Mon Oct  6 05:12:26 2008
New Revision: 36660

URL: http://svn.reactos.org/svn/reactos?rev=36660&view=rev
Log:
Dmitry Gorbachev
- Fix 'overflow in implicit constant conversion' warnings (treated as errors).
See issue #3759 for more details.

Modified:
    trunk/reactos/drivers/usb/nt4compat/usbdriver/ehci.c

Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/ehci.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/nt4compat/usbdriver/ehci.c?rev=36660&r1=36659&r2=36660&view=diff
==============================================================================
--- trunk/reactos/drivers/usb/nt4compat/usbdriver/ehci.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/nt4compat/usbdriver/ehci.c [iso-8859-1] Mon Oct  6 05:12:26 2008
@@ -44,7 +44,7 @@
 #define endp_dir( enDP ) \
 ( DEFAULT_ENDP( enDP )\
   ? 0L\
-  : ( ( enDP )->pusb_endp_desc->bEndpointAddress & USB_DIR_IN ) )
+  : ( ( enDP )->pusb_endp_desc->bEndpointAddress & USB_DIR_IN ) ? 1 : 0 )
 
 #define dev_set_state( pdEV, staTE ) \
 ( pdEV->flags = ( ( pdEV )->flags & ( ~USB_DEV_STATE_MASK ) ) | ( staTE ) )
@@ -2010,7 +2010,7 @@
     pipe_content->trans_type = USB_ENDPOINT_XFER_INT;   // bit 0-1
     pipe_content->speed_high = (pdev->flags & USB_DEV_FLAG_HIGH_SPEED) ? 1 : 0; // bit 5
     pipe_content->speed_low = (pdev->flags & USB_DEV_FLAG_LOW_SPEED) ? 1 : 0;   // bit 6
-    pipe_content->trans_dir = endp_dir(purb->pendp) == USB_DIR_IN ? 1 : 0;      // bit 7
+    pipe_content->trans_dir = endp_dir(purb->pendp);    // bit 7
     pipe_content->dev_addr = pdev->dev_addr;    // bit 8-14
     pipe_content->endp_addr = endp_num(purb->pendp);    // bit 15-18
     pipe_content->data_toggle = 1;      // bit 19
@@ -2216,7 +2216,7 @@
     pipe_content->trans_type = USB_ENDPOINT_XFER_ISOC;  // bit 0-1
     pipe_content->speed_high = (pdev->flags & USB_DEV_FLAG_HIGH_SPEED) ? 1 : 0; // bit 5
     pipe_content->speed_low = 0;        // bit 6
-    pipe_content->trans_dir = endp_dir(purb->pendp) == USB_DIR_IN ? 1 : 0;      // bit 7
+    pipe_content->trans_dir = endp_dir(purb->pendp);    // bit 7
     pipe_content->dev_addr = pdev->dev_addr;    // bit 8-14
     pipe_content->endp_addr = endp_num(purb->pendp);    // bit 15-18
     pipe_content->data_toggle = 0;      // bit 19



More information about the Ros-diffs mailing list