[ros-diffs] [sginsberg] 36680: - HalRequestIpi takes a KAFFINITY as input, not a ULONG -- fix this and add a note about MP HAL's brokenness

[sginsberg at svn.reactos.org]

Author: sginsberg
Date: Tue Oct  7 15:56:48 2008
New Revision: 36680

URL: http://svn.reactos.org/svn/reactos?rev=36680&view=rev
Log:
- HalRequestIpi takes a KAFFINITY as input, not a ULONG -- fix this and add a note about MP HAL's brokenness

Modified:
    trunk/reactos/hal/halx86/generic/processor.c
    trunk/reactos/hal/halx86/mp/ipi_mp.c

Modified: trunk/reactos/hal/halx86/generic/processor.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/processor.c?rev=36680&r1=36679&r2=36680&view=diff
==============================================================================
--- trunk/reactos/hal/halx86/generic/processor.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/processor.c [iso-8859-1] Tue Oct  7 15:56:48 2008
@@ -78,9 +78,9 @@
  */
 VOID
 NTAPI
-HalRequestIpi(ULONG Reserved)
+HalRequestIpi(KAFFINITY TargetProcessors)
 {
-    /* Not implemented on NT */
+    /* Not implemented on UP */
     __debugbreak();
 }
 

Modified: trunk/reactos/hal/halx86/mp/ipi_mp.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/mp/ipi_mp.c?rev=36680&r1=36679&r2=36680&view=diff
==============================================================================
--- trunk/reactos/hal/halx86/mp/ipi_mp.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/mp/ipi_mp.c [iso-8859-1] Tue Oct  7 15:56:48 2008
@@ -16,10 +16,11 @@
 /* FUNCTIONS ****************************************************************/
 
 VOID STDCALL
-HalRequestIpi(ULONG ProcessorNo)
+HalRequestIpi(KAFFINITY TargetProcessors)
 {
-  DPRINT("HalRequestIpi(ProcessorNo %d)\n", ProcessorNo);
-  APICSendIPI(1 << ProcessorNo,
+  /* FIXME: SMP HAL is...very broken */
+  DPRINT("HalRequestIpi(TargetProcessors %d)\n", TargetProcessors);
+  APICSendIPI(1 << TargetProcessors,
 	      IPI_VECTOR|APIC_ICR0_LEVEL_DEASSERT|APIC_ICR0_DESTM);
 }