[ros-diffs] [cgutman] 36739: - Make sure NBAddNeighbor completed successfully - Return the actual status instead of STATUS_SUCCESS always

cgutman at svn.reactos.org cgutman at svn.reactos.org
Mon Oct 13 02:52:25 CEST 2008


Author: cgutman
Date: Sun Oct 12 19:52:25 2008
New Revision: 36739

URL: http://svn.reactos.org/svn/reactos?rev=36739&view=rev
Log:
 - Make sure NBAddNeighbor completed successfully
 - Return the actual status instead of STATUS_SUCCESS always

Modified:
    branches/aicom-network-fixes/lib/drivers/ip/network/neighbor.c
    branches/aicom-network-fixes/lib/drivers/ip/network/transmit.c

Modified: branches/aicom-network-fixes/lib/drivers/ip/network/neighbor.c
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers/ip/network/neighbor.c?rev=36739&r1=36738&r2=36739&view=diff
==============================================================================
--- branches/aicom-network-fixes/lib/drivers/ip/network/neighbor.c [iso-8859-1] (original)
+++ branches/aicom-network-fixes/lib/drivers/ip/network/neighbor.c [iso-8859-1] Sun Oct 12 19:52:25 2008
@@ -412,11 +412,13 @@
             TI_DbgPrint(MID_TRACE,("Packet targeted at broadcast addr\n"));
             NCE = NBAddNeighbor(Interface, Address, NULL,
                                 Interface->AddressLength, NUD_CONNECTED);
+            if (!NCE) return NULL;
             NCE->EventTimer = 0;
             NCE->EventCount = 0;
         } else {
             NCE = NBAddNeighbor(Interface, Address, NULL,
                                 Interface->AddressLength, NUD_INCOMPLETE);
+            if (!NCE) return NULL;
             NCE->EventTimer = 1;
             NCE->EventCount = 0;
         }

Modified: branches/aicom-network-fixes/lib/drivers/ip/network/transmit.c
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers/ip/network/transmit.c?rev=36739&r1=36738&r2=36739&view=diff
==============================================================================
--- branches/aicom-network-fixes/lib/drivers/ip/network/transmit.c [iso-8859-1] (original)
+++ branches/aicom-network-fixes/lib/drivers/ip/network/transmit.c [iso-8859-1] Sun Oct 12 19:52:25 2008
@@ -204,9 +204,7 @@
     /* Prepare next fragment for transmission and send it */
 
     PrepareNextFragment(IFC);
-    IPSendFragment(IFC->NdisPacket, NCE, IFC);
-
-    return STATUS_SUCCESS;
+    return IPSendFragment(IFC->NdisPacket, NCE, IFC);
 }
 
 NTSTATUS IPSendDatagram(PIP_PACKET IPPacket, PNEIGHBOR_CACHE_ENTRY NCE,



More information about the Ros-diffs mailing list