[ros-diffs] [arty] 36421: Fix a legitimate overrun in _widths (coverity 575), and try not to be as clever.

arty at svn.reactos.org arty at svn.reactos.org
Tue Sep 23 11:09:17 CEST 2008


Author: arty
Date: Tue Sep 23 04:09:16 2008
New Revision: 36421

URL: http://svn.reactos.org/svn/reactos?rev=36421&view=rev
Log:
Fix a legitimate overrun in _widths (coverity 575), and try not to be as
clever.

Modified:
    trunk/reactos/base/shell/explorer/shell/pane.cpp

Modified: trunk/reactos/base/shell/explorer/shell/pane.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/shell/pane.cpp?rev=36421&r1=36420&r2=36421&view=diff
==============================================================================
--- trunk/reactos/base/shell/explorer/shell/pane.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/shell/explorer/shell/pane.cpp [iso-8859-1] Tue Sep 23 04:09:16 2008
@@ -774,8 +774,8 @@
 
 	x = _positions[col] + cx;
 
-	for(; col<COLUMNS; ) {
-		_positions[++col] = x;
+	for(; col<COLUMNS; col++) {
+		_positions[col+1] = x;
 		x += _widths[col];
 	}
 



More information about the Ros-diffs mailing list