[ros-diffs] [arty] 36479: Fix my copypasta spotted by (coverity 1294)

arty at svn.reactos.org arty at svn.reactos.org
Wed Sep 24 14:56:31 CEST 2008


Author: arty
Date: Wed Sep 24 07:56:30 2008
New Revision: 36479

URL: http://svn.reactos.org/svn/reactos?rev=36479&view=rev
Log:
Fix my copypasta spotted by (coverity 1294)

Modified:
    trunk/reactos/ntoskrnl/kdbg/kdb.c

Modified: trunk/reactos/ntoskrnl/kdbg/kdb.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.c?rev=36479&r1=36478&r2=36479&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] Wed Sep 24 07:56:30 2008
@@ -1692,7 +1692,7 @@
                     IN PVOID Src,
                     IN ULONG Bytes)
 {
-    BOOLEAN Result;
+    BOOLEAN Result = TRUE;
     ULONG_PTR Start, End, Write;
 
     for (Start = (ULONG_PTR)Src, 
@@ -1700,7 +1700,7 @@
              Write = (ULONG_PTR)Dest; 
          Result && (Start < End); 
          Start++, Write++)
-        if (!KdpSafeReadMemory(Start, 1, (PVOID)Write))
+        if (!KdpSafeWriteMemory(Write, 1, *((PCHAR)Start)))
             Result = FALSE;
 
     return Result ? STATUS_SUCCESS : STATUS_ACCESS_VIOLATION;



More information about the Ros-diffs mailing list