[ros-diffs] [jimtabor] 42011: - Cleanup and minor changes. - The use of CSRSS for creating the desktop window is a cleverly written hack. Real genius! The down side, this is a good example of thread coding, I do hate having to remove it. We could just leave it in there unused to keep it as an example. Let me know.

jimtabor at svn.reactos.org jimtabor at svn.reactos.org
Fri Jul 17 20:41:30 CEST 2009


Author: jimtabor
Date: Fri Jul 17 20:41:29 2009
New Revision: 42011

URL: http://svn.reactos.org/svn/reactos?rev=42011&view=rev
Log:
- Cleanup and minor changes.
- The use of CSRSS for creating the desktop window is a cleverly written hack. Real genius! The down side, this is a good example of thread coding, I do hate having to remove it. We could just leave it in there unused to keep it as an example. Let me know.

Modified:
    trunk/reactos/subsystems/win32/csrss/win32csr/desktopbg.c
    trunk/reactos/subsystems/win32/win32k/ntuser/class.c
    trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c
    trunk/reactos/subsystems/win32/win32k/ntuser/window.c

Modified: trunk/reactos/subsystems/win32/csrss/win32csr/desktopbg.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/win32csr/desktopbg.c?rev=42011&r1=42010&r2=42011&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/win32csr/desktopbg.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/csrss/win32csr/desktopbg.c [iso-8859-1] Fri Jul 17 20:41:29 2009
@@ -11,7 +11,7 @@
 #include "w32csr.h"
 #include <debug.h>
 
-#define DESKTOP_WINDOW_ATOM 32769 //32880
+#define DESKTOP_WINDOW_ATOM 32769
 
 #define PM_SHOW_DESKTOP 1
 #define PM_HIDE_DESKTOP 2

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/class.c?rev=42011&r1=42010&r2=42011&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/class.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c [iso-8859-1] Fri Jul 17 20:41:29 2009
@@ -38,7 +38,7 @@
 static struct
 {
     int FnId;
-    INT ClsId;
+    int ClsId;
 }  FnidToiCls[] =
 {
  { FNID_BUTTON,    ICLS_BUTTON},
@@ -61,7 +61,7 @@
 {
   int i;
   
-  for ( i = 0; i < 11; i++)
+  for ( i = 0; i < (sizeof(FnidToiCls)/2)/sizeof(int); i++)
   {
      if (FnidToiCls[i].FnId == FnId)
      {

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c?rev=42011&r1=42010&r2=42011&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/ntuser.c [iso-8859-1] Fri Jul 17 20:41:29 2009
@@ -1,27 +1,8 @@
 /*
- *  ReactOS W32 Subsystem
- *  Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 ReactOS Team
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
- *  (at your option) any later version.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- *  $Id: painting.c 16320 2005-06-29 07:09:25Z navaraf $
- *
  *  COPYRIGHT:        See COPYING in the top level directory
  *  PROJECT:          ReactOS kernel
  *  PURPOSE:          ntuser init. and main funcs.
- *  FILE:             subsys/win32k/ntuser/ntuser.c
+ *  FILE:             subsystems/win32/win32k/ntuser/ntuser.c
  *  REVISION HISTORY:
  *       16 July 2005   Created (hardon)
  */

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/window.c?rev=42011&r1=42010&r2=42011&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Fri Jul 17 20:41:29 2009
@@ -1,26 +1,8 @@
-/*
- *  ReactOS W32 Subsystem
- *  Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 ReactOS Team
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
- *  (at your option) any later version.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- */
 /*
  * COPYRIGHT:        See COPYING in the top level directory
  * PROJECT:          ReactOS kernel
  * PURPOSE:          Windows
- * FILE:             subsys/win32k/ntuser/window.c
+ * FILE:             subsystems/win32/win32k/ntuser/window.c
  * PROGRAMER:        Casper S. Hornstrup (chorns at users.sourceforge.net)
  * REVISION HISTORY:
  *       06-06-2001  CSH  Created
@@ -1597,7 +1579,7 @@
        * message window (style: WS_POPUP|WS_DISABLED)
        */
       ParentWindowHandle = IntGetMessageWindow();
-      DPRINT1("Parent is HWND_MESSAGE 0x%x\n", ParentWindowHandle);
+      DPRINT("Parent is HWND_MESSAGE 0x%x\n", ParentWindowHandle);
    }
    else if (hWndParent)
    {



More information about the Ros-diffs mailing list