[ros-diffs] [hyperion] 41518: Don't change an std::set in the loop that enumerates it. Patch by Daniel Zimmermann <netzimme at aim.com> See issue #3128 for more details.

hyperion at svn.reactos.org hyperion at svn.reactos.org
Sun Jun 21 23:37:48 CEST 2009


Author: hyperion
Date: Mon Jun 22 01:37:47 2009
New Revision: 41518

URL: http://svn.reactos.org/svn/reactos?rev=41518&view=rev
Log:
Don't change an std::set in the loop that enumerates it. Patch by Daniel Zimmermann <netzimme at aim.com>
See issue #3128 for more details.

Modified:
    trunk/reactos/tools/rbuild/backend/msvc/vcprojmaker.cpp

Modified: trunk/reactos/tools/rbuild/backend/msvc/vcprojmaker.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/msvc/vcprojmaker.cpp?rev=41518&r1=41517&r2=41518&view=diff
==============================================================================
--- trunk/reactos/tools/rbuild/backend/msvc/vcprojmaker.cpp [iso-8859-1] (original)
+++ trunk/reactos/tools/rbuild/backend/msvc/vcprojmaker.cpp [iso-8859-1] Mon Jun 22 01:37:47 2009
@@ -400,11 +400,7 @@
 				fprintf ( OUT, ";" );
 
 			string unescaped = *it1;
-			defines.erase(unescaped);
-			const string& escaped = _replace_str(unescaped, "\"","");
-
-			defines.insert(escaped);
-			fprintf ( OUT, "%s", escaped.c_str() );
+			fprintf ( OUT, "%s", _replace_str(unescaped, "\"","").c_str() );
 		}
 		fprintf ( OUT, "\"\r\n" );
 		fprintf ( OUT, "\t\t\t\tForcedIncludeFiles=\"%s\"\r\n", "warning.h");



More information about the Ros-diffs mailing list