[ros-diffs] [cgutman] 39923: - Replace TcpipBugCheck(0) with ASSERT(FALSE) so memtrack doesn't crash release builds - Remove bug.c and supporting files

cgutman at svn.reactos.org cgutman at svn.reactos.org
Mon Mar 9 21:07:34 CET 2009


Author: cgutman
Date: Mon Mar  9 23:07:33 2009
New Revision: 39923

URL: http://svn.reactos.org/svn/reactos?rev=39923&view=rev
Log:
 - Replace TcpipBugCheck(0) with ASSERT(FALSE) so memtrack doesn't crash release builds
 - Remove bug.c and supporting files

Removed:
    branches/aicom-network-fixes/drivers/network/tcpip/include/bug.h
    branches/aicom-network-fixes/drivers/network/tcpip/tcpip/bug.c
    branches/aicom-network-fixes/drivers/network/tcpip/tcpip/mockbug.c
Modified:
    branches/aicom-network-fixes/drivers/network/tcpip/include/precomp.h
    branches/aicom-network-fixes/drivers/network/tcpip/tcpip.rbuild
    branches/aicom-network-fixes/lib/drivers/ip/network/memtrack.c

Removed: branches/aicom-network-fixes/drivers/network/tcpip/include/bug.h
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/network/tcpip/include/bug.h?rev=39922&view=auto
==============================================================================
--- branches/aicom-network-fixes/drivers/network/tcpip/include/bug.h [iso-8859-1] (original)
+++ branches/aicom-network-fixes/drivers/network/tcpip/include/bug.h (removed)
@@ -1,6 +1,0 @@
-#ifndef _TCPIP_BUG_H
-#define _TCPIP_BUG_H
-
-VOID TcpipBugCheck( ULONG BugCode );
-
-#endif/*_TCPIP_BUG_H*/

Modified: branches/aicom-network-fixes/drivers/network/tcpip/include/precomp.h
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/network/tcpip/include/precomp.h?rev=39923&r1=39922&r2=39923&view=diff
==============================================================================
--- branches/aicom-network-fixes/drivers/network/tcpip/include/precomp.h [iso-8859-1] (original)
+++ branches/aicom-network-fixes/drivers/network/tcpip/include/precomp.h [iso-8859-1] Mon Mar  9 23:07:33 2009
@@ -32,7 +32,6 @@
 #include <fileobjs.h>
 #include <lock.h>
 #include <wait.h>
-#include <bug.h>
 #include <memtrack.h>
 #include <oskittcp.h>
 #include <interface.h>

Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip.rbuild
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/network/tcpip/tcpip.rbuild?rev=39923&r1=39922&r2=39923&view=diff
==============================================================================
--- branches/aicom-network-fixes/drivers/network/tcpip/tcpip.rbuild [iso-8859-1] (original)
+++ branches/aicom-network-fixes/drivers/network/tcpip/tcpip.rbuild [iso-8859-1] Mon Mar  9 23:07:33 2009
@@ -24,7 +24,6 @@
 	</directory>
 	<directory name="tcpip">
 		<file>buffer.c</file>
-		<file>bug.c</file>
 		<file>dispatch.c</file>
 		<file>fileobjs.c</file>
 		<file>iinfo.c</file>

Removed: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/bug.c
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/network/tcpip/tcpip/bug.c?rev=39922&view=auto
==============================================================================
--- branches/aicom-network-fixes/drivers/network/tcpip/tcpip/bug.c [iso-8859-1] (original)
+++ branches/aicom-network-fixes/drivers/network/tcpip/tcpip/bug.c (removed)
@@ -1,11 +1,0 @@
-/*
- * COPYRIGHT:   See COPYING in the top level directory
- * PROJECT:     ReactOS TCP/IP protocol driver
- * FILE:        tcpip/bug.c
- * PURPOSE:     Bugcheck
- * PROGRAMMERS: Art Yerkes
- * REVISIONS:
- */
-#include "precomp.h"
-
-VOID TcpipBugCheck( ULONG BugCode ) { KeBugCheck( BugCode ); }

Removed: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/mockbug.c
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/network/tcpip/tcpip/mockbug.c?rev=39922&view=auto
==============================================================================
--- branches/aicom-network-fixes/drivers/network/tcpip/tcpip/mockbug.c [iso-8859-1] (original)
+++ branches/aicom-network-fixes/drivers/network/tcpip/tcpip/mockbug.c (removed)
@@ -1,14 +1,0 @@
-/*
- * COPYRIGHT:   See COPYING in the top level directory
- * PROJECT:     ReactOS TCP/IP protocol driver
- * FILE:        tcpip/bug.c
- * PURPOSE:     Bugcheck
- * PROGRAMMERS: Art Yerkes
- * REVISIONS:
- */
-#include "precomp.h"
-
-VOID TcpipBugCheck( ULONG BugCode ) {
-    DbgPrint("BugCheck called: %x\n", BugCode);
-    ASSERT(0);
-}

Modified: branches/aicom-network-fixes/lib/drivers/ip/network/memtrack.c
URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers/ip/network/memtrack.c?rev=39923&r1=39922&r2=39923&view=diff
==============================================================================
--- branches/aicom-network-fixes/lib/drivers/ip/network/memtrack.c [iso-8859-1] (original)
+++ branches/aicom-network-fixes/lib/drivers/ip/network/memtrack.c [iso-8859-1] Mon Mar  9 23:07:33 2009
@@ -124,7 +124,7 @@
             if ( ThingInList->Tag != Tag ) {
                  DbgPrint("UNTRACK: TAG DOES NOT MATCH (%x)\n", Thing);
                  ShowTrackedThing("Tag Mismatch (Item in list)", ThingInList, TRUE);
-                 TcpipBugCheck( 0 );
+                 ASSERT( FALSE );
             }
 
 	    ExFreeToNPagedLookasideList( &AllocatedObjectsLookasideList,
@@ -139,7 +139,7 @@
     }
     TcpipReleaseSpinLock( &AllocatedObjectsLock, OldIrql );
     DbgPrint("UNTRACK: SPECIFIED ALREADY FREE ITEM %x\n", Thing);
-    TcpipBugCheck( 0 );
+    ASSERT( FALSE );
 }
 
 VOID TrackDumpFL( PCHAR File, DWORD Line ) {



More information about the Ros-diffs mailing list