[ros-diffs] [cfinck] 40234: - Add background colors to the result comparison instead of text colors - Add a function for comparing the last two results with just one click

cfinck at svn.reactos.org cfinck at svn.reactos.org
Wed Mar 25 17:39:36 CET 2009


Author: cfinck
Date: Wed Mar 25 19:39:35 2009
New Revision: 40234

URL: http://svn.reactos.org/svn/reactos?rev=40234&view=rev
Log:
- Add background colors to the result comparison instead of text colors
- Add a function for comparing the last two results with just one click

Modified:
    branches/danny-web/reactos.org/htdocs/testman/compare.php
    branches/danny-web/reactos.org/htdocs/testman/css/compare.css
    branches/danny-web/reactos.org/htdocs/testman/index.php
    branches/danny-web/reactos.org/htdocs/testman/js/index.js.php
    branches/danny-web/reactos.org/htdocs/testman/lang/de.inc.php
    branches/danny-web/reactos.org/htdocs/testman/lang/en.inc.php
    branches/danny-web/reactos.org/htdocs/testman/lang/pl.inc.php

Modified: branches/danny-web/reactos.org/htdocs/testman/compare.php
URL: http://svn.reactos.org/svn/reactos/branches/danny-web/reactos.org/htdocs/testman/compare.php?rev=40234&r1=40233&r2=40234&view=diff
==============================================================================
--- branches/danny-web/reactos.org/htdocs/testman/compare.php [iso-8859-1] (original)
+++ branches/danny-web/reactos.org/htdocs/testman/compare.php [iso-8859-1] Wed Mar 25 19:39:35 2009
@@ -98,16 +98,16 @@
 	<tr>
 		<td id="intro"><?php echo $testman_langres["legend"]; ?>:</td>
 		
-		<td class="box" style="background: black;"></td>
+		<td class="box totaltests"></td>
 		<td><?php echo $testman_langres["totaltests"]; ?></td>
 		
-		<td class="box" style="background: #BF0A00;"></td>
+		<td class="box failedtests"></td>
 		<td><?php echo $testman_langres["failedtests"]; ?></td>
 		
-		<td class="box" style="background: #1701E4;"></td>
+		<td class="box todotests"></td>
 		<td><?php echo $testman_langres["todotests"]; ?></td>
 		
-		<td class="box" style="background: #818181;"></td>
+		<td class="box skippedtests"></td>
 		<td><?php echo $testman_langres["skippedtests"]; ?></td>
 		
 		<td class="box" style="background: green;"></td>

Modified: branches/danny-web/reactos.org/htdocs/testman/css/compare.css
URL: http://svn.reactos.org/svn/reactos/branches/danny-web/reactos.org/htdocs/testman/css/compare.css?rev=40234&r1=40233&r2=40234&view=diff
==============================================================================
--- branches/danny-web/reactos.org/htdocs/testman/css/compare.css [iso-8859-1] (original)
+++ branches/danny-web/reactos.org/htdocs/testman/css/compare.css [iso-8859-1] Wed Mar 25 19:39:35 2009
@@ -26,19 +26,19 @@
 }
 
 .totaltests {
-	color: black;
+	background-color: #FFFFCC !important;
 }
 
 .failedtests {
-	color: #BF0A00;
+	background-color: #FF6666 !important;
 }
 
 .todotests {
-	color: #1701E4;
+	background-color: #9999FF !important;
 }
 
 .skippedtests {
-	color: #818181;
+	background-color: #CCCCCC !important;
 }
 
 .diff {

Modified: branches/danny-web/reactos.org/htdocs/testman/index.php
URL: http://svn.reactos.org/svn/reactos/branches/danny-web/reactos.org/htdocs/testman/index.php?rev=40234&r1=40233&r2=40234&view=diff
==============================================================================
--- branches/danny-web/reactos.org/htdocs/testman/index.php [iso-8859-1] (original)
+++ branches/danny-web/reactos.org/htdocs/testman/index.php [iso-8859-1] Wed Mar 25 19:39:35 2009
@@ -88,7 +88,10 @@
 					<div class="bubble">
 						<h1><?php echo $testman_langres["lastresults_header"]; ?></h1>
 						
-						<table class="datatable" cellspacing="0" cellpadding="0">
+						<button onclick="CompareLastTwoButton_OnClick()"><?php echo $testman_langres["comparelasttwo_button"]; ?></button>
+						<br /><br />
+						
+						<table id="lastresults" class="datatable" cellspacing="0" cellpadding="0">
 							<thead>
 								<tr class="head">
 									<th class="TestCheckbox"></th>

Modified: branches/danny-web/reactos.org/htdocs/testman/js/index.js.php
URL: http://svn.reactos.org/svn/reactos/branches/danny-web/reactos.org/htdocs/testman/js/index.js.php?rev=40234&r1=40233&r2=40234&view=diff
==============================================================================
--- branches/danny-web/reactos.org/htdocs/testman/js/index.js.php [iso-8859-1] (original)
+++ branches/danny-web/reactos.org/htdocs/testman/js/index.js.php [iso-8859-1] Wed Mar 25 19:39:35 2009
@@ -367,6 +367,21 @@
 	document.getElementById("ajax_loading_search").style.visibility = "hidden";
 }
 
+function CompareLastTwoButton_OnClick()
+{
+	var parameters = "ids=";
+	var trs = document.getElementById("lastresults").getElementsByTagName("tbody")[0].getElementsByTagName("tr");
+	
+	if(trs.length < 2)
+		return;
+	
+	// Get the IDs through the "name" attribute of the checkboxes	
+	parameters += trs[1].firstChild.firstChild.name.substr(5) + ",";
+	parameters += trs[0].firstChild.firstChild.name.substr(5);
+	
+	window.open("compare.php?" + parameters);
+}
+
 function PageSwitch(NewPage, StartID)
 {
 	CurrentPage = NewPage;

Modified: branches/danny-web/reactos.org/htdocs/testman/lang/de.inc.php
URL: http://svn.reactos.org/svn/reactos/branches/danny-web/reactos.org/htdocs/testman/lang/de.inc.php?rev=40234&r1=40233&r2=40234&view=diff
==============================================================================
--- branches/danny-web/reactos.org/htdocs/testman/lang/de.inc.php [iso-8859-1] (original)
+++ branches/danny-web/reactos.org/htdocs/testman/lang/de.inc.php [iso-8859-1] Wed Mar 25 19:39:35 2009
@@ -17,6 +17,7 @@
 		"js_disclaimer" => "Sie müssen JavaScript aktivieren, um die Oberfläche zu benutzen!",
 		
 		"lastresults_header" => "Letzte 10 Testergebnisse",
+		"comparelasttwo_button" => "Letzte zwei Ergebnisse vergleichen",
 		"date" => "Datum",
 		"revision" => "Revision",
 		"user" => "Benutzer",

Modified: branches/danny-web/reactos.org/htdocs/testman/lang/en.inc.php
URL: http://svn.reactos.org/svn/reactos/branches/danny-web/reactos.org/htdocs/testman/lang/en.inc.php?rev=40234&r1=40233&r2=40234&view=diff
==============================================================================
--- branches/danny-web/reactos.org/htdocs/testman/lang/en.inc.php [iso-8859-1] (original)
+++ branches/danny-web/reactos.org/htdocs/testman/lang/en.inc.php [iso-8859-1] Wed Mar 25 19:39:35 2009
@@ -17,6 +17,7 @@
 		"js_disclaimer" => "You have to activate JavaScript to use the interface!",
 		
 		"lastresults_header" => "Last 10 Test Results",
+		"comparelasttwo_button" => "Compare last two Results",
 		"date" => "Date",
 		"revision" => "Revision",
 		"user" => "User",

Modified: branches/danny-web/reactos.org/htdocs/testman/lang/pl.inc.php
URL: http://svn.reactos.org/svn/reactos/branches/danny-web/reactos.org/htdocs/testman/lang/pl.inc.php?rev=40234&r1=40233&r2=40234&view=diff
==============================================================================
--- branches/danny-web/reactos.org/htdocs/testman/lang/pl.inc.php [iso-8859-1] (original)
+++ branches/danny-web/reactos.org/htdocs/testman/lang/pl.inc.php [iso-8859-1] Wed Mar 25 19:39:35 2009
@@ -18,6 +18,7 @@
 		"js_disclaimer" => "Musisz wÅ‚Ä
czyć obsługę JavaScriptu, aby używać tego interfejsu!",
 		
 		"lastresults_header" => "10 ostatnich wyników testów",
+		"comparelasttwo_button" => "Porównaj dwa ostatnie wyniki testów",
 		"date" => "Data",
 		"revision" => "Rewizja",
 		"user" => "Użytkownik",



More information about the Ros-diffs mailing list