[ros-diffs] [janderwald] 40822: - Only call ReleaseStgMedium when IDataObject_GetData has succeeded - Fixes explorer crashing on context menu click

janderwald at svn.reactos.org janderwald at svn.reactos.org
Thu May 7 00:07:53 CEST 2009


Author: janderwald
Date: Thu May  7 02:07:53 2009
New Revision: 40822

URL: http://svn.reactos.org/svn/reactos?rev=40822&view=rev
Log:
- Only call ReleaseStgMedium when IDataObject_GetData has succeeded
- Fixes explorer crashing on context menu click

Modified:
    trunk/reactos/dll/win32/shell32/shv_def_cmenu.c

Modified: trunk/reactos/dll/win32/shell32/shv_def_cmenu.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shv_def_cmenu.c?rev=40822&r1=40821&r2=40822&view=diff
==============================================================================
--- trunk/reactos/dll/win32/shell32/shv_def_cmenu.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/shv_def_cmenu.c [iso-8859-1] Thu May  7 02:07:53 2009
@@ -299,10 +299,10 @@
       if(SUCCEEDED(IDataObject_GetData(pda,&formatetc,&medium)))
       {
           ret = TRUE;
+          ReleaseStgMedium(&medium);		  
       }
 
       IDataObject_Release(pda);
-      ReleaseStgMedium(&medium);
     }
 
     return ret;



More information about the Ros-diffs mailing list