[ros-diffs] [sginsberg] 43871: - Don't define the SizePcr entry to the size of the PCR PLUS the PRCB SIZE! The PRCB size is already defined in the SizePrcb entry. - Likewise, the OffsetPrcbProcStateSpecialReg entry defines the offset to the special registers in the PRCB, not a PCR + PRCB offset + special registers offset! This can only have worked on x86 and AMD64 if WinDbg uses a hard coded offset, but define it correctly anyway. - The OffsetPcrSelfPcr and OffsetPcrContainedPrcb entries are not applicable for ARM, so define them to 0 for it.
sginsberg at svn.reactos.org
sginsberg at svn.reactos.org
Sat Oct 31 14:46:17 CET 2009
- Previous message: [ros-diffs] [fireball] 43870: [usetup] - Change "MBR" to "bootsector", as proposed in bug 4356 by Michael Trausch. Changed languages are English and Russian.
- Next message: [ros-diffs] [ahill] 43872: [browseui, shell32, explorer_new, include] - Convert browseui to C++/ATL. As part of this, classes in browseui and now registered with .rgs files. - Add AddressBand, AddressEditBox, BandProxy, BaseBar, BaseBarSite, BrandBand, InternetToolbar, ShellBrowser, ToolsBand, and TravelLog. - Add stub implementations of commonbrowser, globalfoldersettings, and regtreeoptions. - Clean up some msvc compile problems in a few files. - Reorganize some headers to make them better match the Platform SDK. - Move InlineIsEqualGUID to guiddef.h. - Create new header files shlguid_undoc.h, shlobj_undoc.h, and shlwapi_undoc.h to hold undocumented types, functions, and GUIDs. - Move some undocumented definitions declared in explorer_new/todo.h and undoc.h to new headers. - Rename a few interfaces in explorer_new to the correct name - Add definition of RBSTR_CHANGERECT to commctrl.h - IDeskBarClient inherits from IOleWindow, not IUnknown - HMONITOR was declared in both dxsdk/axextend.idl and wine/wined3d.idl, but not in wtypes.idl where it belongs - Added Init and Term to CComModule - Thanks to encoded for solving the browseui linking problem!
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: sginsberg
Date: Sat Oct 31 14:46:16 2009
New Revision: 43871
URL: http://svn.reactos.org/svn/reactos?rev=43871&view=rev
Log:
- Don't define the SizePcr entry to the size of the PCR PLUS the PRCB SIZE! The PRCB size is already defined in the SizePrcb entry.
- Likewise, the OffsetPrcbProcStateSpecialReg entry defines the offset to the special registers in the PRCB, not a PCR + PRCB offset + special registers offset! This can only have worked on x86 and AMD64 if WinDbg uses a hard coded offset, but define it correctly anyway.
- The OffsetPcrSelfPcr and OffsetPcrContainedPrcb entries are not applicable for ARM, so define them to 0 for it.
Modified:
trunk/reactos/ntoskrnl/kd64/kddata.c
Modified: trunk/reactos/ntoskrnl/kd64/kddata.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd64/kddata.c?rev=43871&r1=43870&r2=43871&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/kd64/kddata.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/kd64/kddata.c [iso-8859-1] Sat Oct 31 14:46:16 2009
@@ -36,9 +36,9 @@
#elif defined(_M_ARM)
-//#define KPCR_SELF_OFFSET
+#define KPCR_SELF_OFFSET 0
#define KPCR_CURRENT_PRCB_OFFSET FIELD_OFFSET(KPCR, Prcb)
-//#define KPCR_CONTAINED_PRCB_OFFSET
+#define KPCR_CONTAINED_PRCB_OFFSET 0
#else
#error Unsupported Architecture
@@ -485,7 +485,7 @@
{(ULONG_PTR)KdPrintDefaultCircularBuffer},
{(ULONG_PTR)&KdPrintBufferSize},
{(ULONG_PTR)&KeLoaderBlock},
- sizeof(KPCR) + sizeof(KPRCB),
+ sizeof(KPCR),
KPCR_SELF_OFFSET,
KPCR_CURRENT_PRCB_OFFSET,
KPCR_CONTAINED_PRCB_OFFSET,
@@ -494,7 +494,6 @@
0,
0,
0,
- KPCR_CONTAINED_PRCB_OFFSET +
FIELD_OFFSET(KPRCB, ProcessorState.SpecialRegisters),
#if defined(_M_IX86)
//
- Previous message: [ros-diffs] [fireball] 43870: [usetup] - Change "MBR" to "bootsector", as proposed in bug 4356 by Michael Trausch. Changed languages are English and Russian.
- Next message: [ros-diffs] [ahill] 43872: [browseui, shell32, explorer_new, include] - Convert browseui to C++/ATL. As part of this, classes in browseui and now registered with .rgs files. - Add AddressBand, AddressEditBox, BandProxy, BaseBar, BaseBarSite, BrandBand, InternetToolbar, ShellBrowser, ToolsBand, and TravelLog. - Add stub implementations of commonbrowser, globalfoldersettings, and regtreeoptions. - Clean up some msvc compile problems in a few files. - Reorganize some headers to make them better match the Platform SDK. - Move InlineIsEqualGUID to guiddef.h. - Create new header files shlguid_undoc.h, shlobj_undoc.h, and shlwapi_undoc.h to hold undocumented types, functions, and GUIDs. - Move some undocumented definitions declared in explorer_new/todo.h and undoc.h to new headers. - Rename a few interfaces in explorer_new to the correct name - Add definition of RBSTR_CHANGERECT to commctrl.h - IDeskBarClient inherits from IOleWindow, not IUnknown - HMONITOR was declared in both dxsdk/axextend.idl and wine/wined3d.idl, but not in wtypes.idl where it belongs - Added Init and Term to CComModule - Thanks to encoded for solving the browseui linking problem!
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list