[ros-diffs] [fireball] 48737: [NTOS] - Fix a code typo which led to a security issue when the XOR algorithm for the system cookie might actually yield zero. Now it's going to loop as long as the cookie is 0, a...

fireball at svn.reactos.org fireball at svn.reactos.org
Fri Sep 10 21:13:07 UTC 2010


Author: fireball
Date: Fri Sep 10 21:13:06 2010
New Revision: 48737

URL: http://svn.reactos.org/svn/reactos?rev=48737&view=rev
Log:
[NTOS]
- Fix a code typo which led to a security issue when the XOR algorithm for the system cookie might actually yield zero. Now it's going to loop as long as the cookie is 0, attempting to generate a non-zero one.

Modified:
    trunk/reactos/ntoskrnl/ps/thread.c

Modified: trunk/reactos/ntoskrnl/ps/thread.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/thread.c?rev=48737&r1=48736&r2=48737&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ps/thread.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ps/thread.c [iso-8859-1] Fri Sep 10 21:13:06 2010
@@ -91,7 +91,7 @@
     }
 
     /* Do we have a cookie set yet? */
-    if (!SharedUserData->Cookie)
+    while (!SharedUserData->Cookie)
     {
         LARGE_INTEGER SystemTime;
         ULONG NewCookie;




More information about the Ros-diffs mailing list