[ros-diffs] [tfaber] 53483: [CMAKE] - Remove some hacks from ntdll and msvcrt build files - Bring msvcrt* files in better sync

[tfaber at svn.reactos.org]

Author: tfaber
Date: Sun Aug 28 18:28:18 2011
New Revision: 53483

URL: http://svn.reactos.org/svn/reactos?rev=53483&view=rev
Log:
[CMAKE]
- Remove some hacks from ntdll and msvcrt build files
- Bring msvcrt* files in better sync

Modified:
    trunk/reactos/dll/ntdll/CMakeLists.txt
    trunk/reactos/dll/win32/msvcrt/CMakeLists.txt
    trunk/reactos/dll/win32/msvcrt20/CMakeLists.txt
    trunk/reactos/dll/win32/msvcrt40/CMakeLists.txt

Modified: trunk/reactos/dll/ntdll/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/CMakeLists.txt?rev=53483&r1=53482&r2=53483&view=diff
==============================================================================
--- trunk/reactos/dll/ntdll/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/CMakeLists.txt [iso-8859-1] Sun Aug 28 18:28:18 2011
@@ -15,23 +15,23 @@
     csr/capture.c
     csr/connect.c
     dbg/dbgui.c
-	ldr/ldrapi.c
-	ldr/ldrinit.c
-	ldr/ldrpe.c
-	ldr/ldrutils.c
+    ldr/ldrapi.c
+    ldr/ldrinit.c
+    ldr/ldrpe.c
+    ldr/ldrutils.c
     rtl/libsupp.c
     rtl/version.c
     def/ntdll.rc
     ${CMAKE_CURRENT_BINARY_DIR}/ntdll.def)
-    
+
 if(ARCH MATCHES i386)
-list(APPEND SOURCE dispatch/i386/dispatch.S)
+    list(APPEND SOURCE dispatch/i386/dispatch.S)
 elseif(ARCH MATCHES amd64)
-list(APPEND SOURCE dispatch/amd64/stubs.c)
+    list(APPEND SOURCE dispatch/amd64/stubs.c)
 elseif(ARCH MATCHES arm)
-list(APPEND SOURCE dispatch/arm/stubs_asm.s)
+    list(APPEND SOURCE dispatch/arm/stubs_asm.s)
 else()
-list(APPEND SOURCE dispatch/dispatch.c)
+    list(APPEND SOURCE dispatch/dispatch.c)
 endif(ARCH MATCHES i386)
 
 add_library(ntdll SHARED ${SOURCE})
@@ -39,13 +39,11 @@
 set_entrypoint(ntdll 0)
 
 if(MSVC)
-target_link_libraries(ntdll rtl)
-add_linkerflag(ntdll /RELEASE)
-else()
-target_link_libraries(ntdll -Wl,--whole-archive rtl -Wl,--no-whole-archive)
+    add_linkerflag(ntdll /RELEASE)
 endif()
 
 target_link_libraries(ntdll
+                      rtl
                       ntdllsys
                       libcntpr
                       ${PSEH_LIB})

Modified: trunk/reactos/dll/win32/msvcrt/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/CMakeLists.txt?rev=53483&r1=53482&r2=53483&view=diff
==============================================================================
--- trunk/reactos/dll/win32/msvcrt/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/msvcrt/CMakeLists.txt [iso-8859-1] Sun Aug 28 18:28:18 2011
@@ -23,20 +23,15 @@
 
 add_library(msvcrt SHARED ${SOURCE})
 
-if(NOT MSVC)
-    set_target_properties(msvcrt PROPERTIES LINK_FLAGS "-u __seh_longjmp_unwind at 4")
-endif()
-
 add_dependencies(msvcrt psdk)
 set_entrypoint(msvcrt DllMain 12)
 set_image_base(msvcrt ${baseaddress_msvcrt})
 
-target_link_libraries(msvcrt crt wine)
+target_link_libraries(msvcrt crt wine ${PSEH_LIB})
 
 if(MSVC)
+    # export of deleting destructor "name"
     add_linkerflag(msvcrt "/ignore:4102")
-else()
-    target_link_libraries(msvcrt pseh)
 endif()
 
 add_importlibs(msvcrt kernel32 ntdll)

Modified: trunk/reactos/dll/win32/msvcrt20/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt20/CMakeLists.txt?rev=53483&r1=53482&r2=53483&view=diff
==============================================================================
--- trunk/reactos/dll/win32/msvcrt20/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/msvcrt20/CMakeLists.txt [iso-8859-1] Sun Aug 28 18:28:18 2011
@@ -1,3 +1,5 @@
+
+spec2def(msvcrt20.dll msvcrt20.spec)
 
 add_definitions(
     -DUSE_MSVCRT_PREFIX
@@ -11,8 +13,6 @@
 
 include_directories(${REACTOS_SOURCE_DIR}/lib/sdk/crt/include)
 
-spec2def(msvcrt20.dll msvcrt20.spec)
-
 list(APPEND SOURCE
     msvcrt20.c
     stubs.c
@@ -20,17 +20,18 @@
     ${CMAKE_CURRENT_BINARY_DIR}/msvcrt20.def)
 
 add_library(msvcrt20 SHARED ${SOURCE})
+
+add_dependencies(msvcrt20 psdk)
 set_entrypoint(msvcrt20 DllMain 12)
 set_image_base(msvcrt20 ${baseaddress_msvcrt20})
 
-target_link_libraries(msvcrt20 crt wine)
+target_link_libraries(msvcrt20 crt wine ${PSEH_LIB})
 
 if(MSVC)
+    # export of deleting destructor "name"
     add_linkerflag(msvcrt20 "/ignore:4102")
-else()
-    target_link_libraries(msvcrt20 pseh)
 endif()
 
 add_importlibs(msvcrt20 kernel32 ntdll)
-add_dependencies(msvcrt20 psdk)
+
 add_cd_file(TARGET msvcrt20 DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/dll/win32/msvcrt40/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt40/CMakeLists.txt?rev=53483&r1=53482&r2=53483&view=diff
==============================================================================
--- trunk/reactos/dll/win32/msvcrt40/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/msvcrt40/CMakeLists.txt [iso-8859-1] Sun Aug 28 18:28:18 2011
@@ -1,3 +1,5 @@
+
+spec2def(msvcrt40.dll msvcrt40.spec)
 
 add_definitions(
     -DUSE_MSVCRT_PREFIX
@@ -11,8 +13,6 @@
 
 include_directories(${REACTOS_SOURCE_DIR}/lib/sdk/crt/include)
 
-spec2def(msvcrt40.dll msvcrt40.spec)
-
 list(APPEND SOURCE
     msvcrt40.c
     stubs.c
@@ -20,15 +20,16 @@
     ${CMAKE_CURRENT_BINARY_DIR}/msvcrt40.def)
 
 add_library(msvcrt40 SHARED ${SOURCE})
+
+add_dependencies(msvcrt40 psdk)
+set_entrypoint(msvcrt40 DllMain 12)
 set_image_base(msvcrt40 ${baseaddress_msvcrt40})
-set_entrypoint(msvcrt40 DllMain 12)
 
-target_link_libraries(msvcrt40 crt wine)
+target_link_libraries(msvcrt40 crt wine ${PSEH_LIB})
 
 if(MSVC)
+    # export of deleting destructor "name"
     add_linkerflag(msvcrt40 "/ignore:4102")
-else()
-    target_link_libraries(msvcrt40 pseh)
 endif()
 
 add_importlibs(msvcrt40 kernel32 ntdll)