[ros-diffs] [rmessiant] 51027: [APPLICATIONS] - Change all C function prototype declarations with an empty argument list to use void, or the list specified in the function definition. According to the C langua...
rmessiant at svn.reactos.org
rmessiant at svn.reactos.org
Sat Mar 12 19:03:29 UTC 2011
Author: rmessiant
Date: Sat Mar 12 19:03:27 2011
New Revision: 51027
URL: http://svn.reactos.org/svn/reactos?rev=51027&view=rev
Log:
[APPLICATIONS]
- Change all C function prototype declarations with an empty argument list to use void, or the list specified in the function definition.
According to the C language specification, such a declaration means "no information about the number or types of the parameters is supplied".
This can expose cases where gcc allows us to pass an excessive amount of arguments to functions in certain cases.
Thanks to Thomas Faber for informing us about this.
Modified:
trunk/reactos/base/applications/dxdiag/precomp.h
trunk/reactos/base/applications/games/solitaire/solitaire.h
trunk/reactos/base/applications/games/spider/spider.h
trunk/reactos/base/applications/magnify/magnifier.h
trunk/reactos/base/applications/network/ftp/ftp_var.h
trunk/reactos/base/applications/network/ftp/prototypes.h
trunk/reactos/base/applications/network/net/net.h
trunk/reactos/base/applications/paint/dialogs.h
trunk/reactos/base/applications/paint/history.h
trunk/reactos/base/applications/paint/mouse.h
Modified: trunk/reactos/base/applications/dxdiag/precomp.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/dxdiag/precomp.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/dxdiag/precomp.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/dxdiag/precomp.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -43,10 +43,10 @@
INT_PTR CALLBACK HelpPageWndProc(HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam);
/* DirectDraw tests */
-VOID DDTests();
+VOID DDTests(VOID);
/* Direct3D tests */
-VOID D3DTests();
+VOID D3DTests(VOID);
/* DirectSound initialization */
void InitializeDirectSoundPage(PDXDIAG_CONTEXT pContext);
Modified: trunk/reactos/base/applications/games/solitaire/solitaire.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/solitaire/solitaire.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/games/solitaire/solitaire.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/games/solitaire/solitaire.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -16,7 +16,7 @@
extern DWORD dwOptions;
-void CreateSol();
+void CreateSol(void);
void NewGame(void);
#define NUM_ROW_STACKS 7
Modified: trunk/reactos/base/applications/games/spider/spider.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/spider/spider.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/games/spider/spider.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/games/spider/spider.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -25,7 +25,7 @@
extern TCHAR MsgDeal[];
extern TCHAR MsgWin[];
-void CreateSpider();
+void CreateSpider(void);
void NewGame(void);
bool CARDLIBPROC RowStackDragProc(CardRegion &stackobj, int iNumCards);
Modified: trunk/reactos/base/applications/magnify/magnifier.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/magnifier.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/magnify/magnifier.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/magnify/magnifier.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -32,5 +32,5 @@
extern BOOL bStartMinimized;
extern BOOL bShowMagnifier;
-void LoadSettings();
-void SaveSettings();
+void LoadSettings(void);
+void SaveSettings(void);
Modified: trunk/reactos/base/applications/network/ftp/ftp_var.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/ftp/ftp_var.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/ftp/ftp_var.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/ftp/ftp_var.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -141,7 +141,7 @@
char c_bell; /* give bell when command completes */
char c_conn; /* must be connected to use command */
char c_proxy; /* proxy server may execute */
- void (*c_handler)(); /* function to call */
+ void (*c_handler)(void); /* function to call */
};
struct macel {
Modified: trunk/reactos/base/applications/network/ftp/prototypes.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/ftp/prototypes.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/ftp/prototypes.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/ftp/prototypes.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -8,8 +8,8 @@
int fputSocket(int s, char *putChar, int len);
char *fgetsSocket(int s, char *string);
-char *hookup();
-char **glob();
+char *hookup(void);
+char **glob(void);
int herror(char *s);
int getreply(int expecteof);
@@ -43,22 +43,22 @@
int getit(int argc, const char *argv[], int restartit, const char *mode);
int sleep(int time);
-char *tail();
-void setbell(), setdebug();
-void setglob(), sethash(), setport();
-void setprompt();
-void settrace(), setverbose();
-void settype(), setform(), setstruct();
-void restart(), syst();
-void cd(), lcd(), delete(), mdelete();
-void ls(), mls(), get(), mget(), help(), append(), put(), mput(), reget();
-void status();
-void renamefile();
-void quote(), rmthelp(), site();
-void pwd(), makedir(), removedir(), setcr();
-void account(), doproxy(), reset(), setcase(), setntrans(), setnmap();
-void setsunique(), setrunique(), cdup(), macdef();
-void sizecmd(), modtime(), newer(), rmtstatus();
-void do_chmod(), do_umask(), idle();
-void shell(), user(), fsetmode();
-struct cmd *getcmd();
+char *tail(void);
+void setbell(void), setdebug(void);
+void setglob(void), sethash(void), setport(void);
+void setprompt(void);
+void settrace(void), setverbose(void);
+void settype(void), setform(void), setstruct(void);
+void restart(void), syst(void);
+void cd(void), lcd(void), delete(void), mdelete(void);
+void ls(void), mls(void), get(void), mget(void), help(void), append(void), put(void), mput(void), reget(void);
+void status(void);
+void renamefile(void);
+void quote(void), rmthelp(void), site(void);
+void pwd(void), makedir(void), removedir(void), setcr(void);
+void account(void), doproxy(void), reset(void), setcase(void), setntrans(void), setnmap(void);
+void setsunique(void), setrunique(void), cdup(void), macdef(void);
+void sizecmd(void), modtime(void), newer(void), rmtstatus(void);
+void do_chmod(void), do_umask(void), idle(void);
+void shell(void), user(void), fsetmode(void);
+struct cmd *getcmd(void);
Modified: trunk/reactos/base/applications/network/net/net.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/net/net.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/net/net.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/net/net.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -13,8 +13,8 @@
#include <stdlib.h>
#include <windows.h>
-void help();
-int unimplemented();
+void help(void);
+int unimplemented(void);
INT cmdHelp(INT argc, CHAR **argv);
Modified: trunk/reactos/base/applications/paint/dialogs.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/paint/dialogs.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/paint/dialogs.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/paint/dialogs.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -6,8 +6,8 @@
* PROGRAMMERS: Benedikt Freisen
*/
-int mirrorRotateDlg();
+int mirrorRotateDlg(void);
-int attributesDlg();
+int attributesDlg(void);
int changeSizeDlg();
Modified: trunk/reactos/base/applications/paint/history.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/paint/history.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/paint/history.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/paint/history.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -6,16 +6,16 @@
* PROGRAMMERS: Benedikt Freisen
*/
-void newReversible();
+void newReversible(void);
-void undo();
+void undo(void);
-void redo();
+void redo(void);
-void resetToU1();
+void resetToU1(void);
-void clearHistory();
+void clearHistory(void);
-void insertReversible();
+void insertReversible(HBITMAP hbm);
void cropReversible(int width, int height, int xOffset, int yOffset);
Modified: trunk/reactos/base/applications/paint/mouse.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/paint/mouse.h?rev=51027&r1=51026&r2=51027&view=diff
==============================================================================
--- trunk/reactos/base/applications/paint/mouse.h [iso-8859-1] (original)
+++ trunk/reactos/base/applications/paint/mouse.h [iso-8859-1] Sat Mar 12 19:03:27 2011
@@ -6,7 +6,7 @@
* PROGRAMMERS: Benedikt Freisen
*/
-void placeSelWin();
+void placeSelWin(void);
void startPaintingL(HDC hdc, short x, short y, int fg, int bg);
More information about the Ros-diffs
mailing list