[ros-diffs] [tkreuzer] 56272: [NTOSKRNL] "while (TRUE); " is probably the worst way of handling critical errors / unhandled failure pathes! Replace that with ASSERT(FALSE);

[tkreuzer at svn.reactos.org]

Author: tkreuzer
Date: Thu Mar 29 10:14:47 2012
New Revision: 56272

URL: http://svn.reactos.org/svn/reactos?rev=56272&view=rev
Log:
[NTOSKRNL]
"while (TRUE);" is probably the worst way of handling critical errors / unhandled failure pathes! Replace that with ASSERT(FALSE);

Modified:
    trunk/reactos/ntoskrnl/mm/ARM3/section.c

Modified: trunk/reactos/ntoskrnl/mm/ARM3/section.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/section.c?rev=56272&r1=56271&r2=56272&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ARM3/section.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/section.c [iso-8859-1] Thu Mar 29 10:14:47 2012
@@ -391,8 +391,7 @@
         if (ProtoPte >= LastProtoPte)
         {
             /* But we don't handle this yet */
-            UNIMPLEMENTED;
-            while (TRUE);
+            ASSERT(FALSE);
         }
 
         /* The PTE should be completely clear */
@@ -717,8 +716,7 @@
     if (*ViewSize > SectionSize)
     {
         /* We should probably fail. FIXME TODO */
-        UNIMPLEMENTED;
-        while (TRUE);
+        ASSERT(FALSE);
     }
 
     /* Get the number of 64K buckets required for this mapping */
@@ -729,8 +727,7 @@
     if (Buckets >= MI_SYSTEM_VIEW_BUCKET_SIZE)
     {
         /* We should probably fail */
-        UNIMPLEMENTED;
-        while (TRUE);
+        ASSERT(FALSE);
     }
 
     /* Insert this view into system space and get a base address for it */