[ros-diffs] [tkreuzer] 56495: [GDI32_APITEST] - Comment out a broken test (works only on 32bpp) - Fix MSVC warning

tkreuzer at svn.reactos.org tkreuzer at svn.reactos.org
Fri May 4 12:32:11 UTC 2012


Author: tkreuzer
Date: Fri May  4 12:32:11 2012
New Revision: 56495

URL: http://svn.reactos.org/svn/reactos?rev=56495&view=rev
Log:
[GDI32_APITEST]
- Comment out a broken test (works only on 32bpp)
- Fix MSVC warning

Modified:
    trunk/rostests/apitests/gdi32/SetDCPenColor.c
    trunk/rostests/apitests/gdi32/SetPixel.c

Modified: trunk/rostests/apitests/gdi32/SetDCPenColor.c
URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32/SetDCPenColor.c?rev=56495&r1=56494&r2=56495&view=diff
==============================================================================
--- trunk/rostests/apitests/gdi32/SetDCPenColor.c [iso-8859-1] (original)
+++ trunk/rostests/apitests/gdi32/SetDCPenColor.c [iso-8859-1] Fri May  4 12:32:11 2012
@@ -12,7 +12,7 @@
 void Test_SetDCPenColor()
 {
 	HDC hScreenDC, hDC;
-	HBITMAP hbmp;
+	HBITMAP hbmp, hbmpOld;
 
 	// Test an incorrect DC
 	SetLastError(ERROR_SUCCESS);
@@ -49,13 +49,15 @@
 	hbmp = CreateBitmap(10, 10, 1, 32, NULL);
 	ok(hbmp != 0, "CreateBitmap failed, skipping tests\n");
 	if (!hbmp) return;
-
-	SelectObject(hDC, hbmp);
+	hbmpOld = SelectObject(hDC, hbmp);
+#if 0 // this only works on 32 bpp screen resolution
+	ok(hbmpOld != NULL, "\n");
 	SelectObject(hDC, GetStockObject(DC_PEN));
 	SetDCPenColor(hDC, 0x123456);
 	MoveToEx(hDC, 0, 0, NULL);
 	LineTo(hDC, 10, 0);
 	ok(GetPixel(hDC, 5, 0) == 0x123456, "\n");
+#endif
 
 	// Delete the DC
 	DeleteDC(hDC);

Modified: trunk/rostests/apitests/gdi32/SetPixel.c
URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32/SetPixel.c?rev=56495&r1=56494&r2=56495&view=diff
==============================================================================
--- trunk/rostests/apitests/gdi32/SetPixel.c [iso-8859-1] (original)
+++ trunk/rostests/apitests/gdi32/SetPixel.c [iso-8859-1] Fri May  4 12:32:11 2012
@@ -71,7 +71,7 @@
     HDC hdc;
     HPALETTE hpal, hpalOld;
     PULONG pulBits;
-    ULONG i;
+    USHORT i;
 
     /* Initialize the BITMAPINFO */
     pbmi->bmiHeader.biSize = sizeof(BITMAPINFOHEADER);




More information about the Ros-diffs mailing list